Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2131801

Summary: [gnome-shell] some translations are not applicable due to how the original code was patched
Product: Red Hat Enterprise Linux 9 Reporter: paadpi
Component: gnome-shellAssignee: Florian Müllner <fmuellner>
Status: CLOSED ERRATA QA Contact: Sanket Saikia <ssaikia>
Severity: low Docs Contact:
Priority: unspecified    
Version: CentOS StreamCC: bstinson, jadahl, jkoten, jwboyer, ljanda, rstrode, tpelka, tpopela
Target Milestone: rcKeywords: Translation, Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: gnome-shell-40.10-8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-09 07:41:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
screenshot none

Description paadpi 2022-10-03 17:17:51 UTC
Created attachment 1915772 [details]
screenshot

Created attachment 1915772 [details]
screenshot

Description of problem:

Some translations translated by gnome team are skipped due to patches applied. 


Version-Release number of selected component (if applicable): 40.10-3


Steps to Reproduce:

1. Change language to any different than English.

2. Make welcome screen pop up during next log in.
dconf write /org/gnome/shell/welcome-dialog-last-shown-version "''" 

3. Login to gnome session again.


Actual results:

"Welcome to" string is not translated. (screenshot in attachment)


Expected results:

I should be translated.


Additional info:

The procedure to fix missing translation is:

1. Execute %prep for gnome-shell source.
rpmbuild -rp gnome-shell*.src.rpm

2. Go into build directory.
cd ~/rpmbuild/BUILD/gnome-shell*

3. Prepare meson build.
mkdir ninja && meson ninja

4. Update locale *.po files
cd ninja && meson compile gnome-shell-update-po

5. Fix translation which you can. (check #fuzzy tags!!)
cd .. && vim po/fr.po

6. Format patch and apply it to the SOURCE and spec.

Comment 1 paadpi 2022-10-03 17:27:09 UTC
I made a patch for polish localization. https://gitlab.com/paadpi/gnome-shell

Comment 2 Tomas Popela 2022-10-04 06:51:14 UTC
Isn't the main problem the https://gitlab.com/redhat/centos-stream/rpms/gnome-shell/-/blob/c9s/0001-welcomeDialog-Adapt-dialog-title.patch patch that is changing the string and hence the translations are not used as the po files still reference the old one (with "GNOME" in it)?

(from cs.po):
#: js/ui/welcomeDialog.js:36
#, javascript-format
msgid "Welcome to GNOME %s"
msgstr "Vítá vás GNOME %s"

Comment 3 paadpi 2022-10-04 09:33:21 UTC
Yes, it is the reason of fuzzy localization for the welcome screen. However, there are more fuzzy translations, after po files update (meson compile gnome-shell-update-po) in patched source code.

For example in fr.po:

#: js/ui/status/powerProfiles.js:21
#, fuzzy
msgctxt "Power profile"
msgid "Power Saver"
msgstr "Paramètres de gestion de l’énergie"

#: js/ui/welcomeDialog.js:34
#, fuzzy, javascript-format
msgid "Welcome to %s"
msgstr "Bienvenue dans GNOME %s"

#: js/ui/windowMenu.js:123
#, fuzzy
msgid "Move to another workspace"
msgstr "Déplacer vers l’espace de travail supérieur"

Comment 4 Florian Müllner 2022-10-21 12:46:52 UTC
Yes, all (supported) translations need an update downstream.

The alternative of keeping the upstream translation and replace "GNOME" programmatically with the OS branding would only work for locales where "GNOME" as translated as "GNOME". That is not the case for all available languages (in particular with non-latin scripts).

Comment 5 Tomas Popela 2023-01-12 16:39:37 UTC
@ljanda we will need help of your team to address this issue. We will need new downstream translations for 'Welcome to %s' string (the original one is modified with https://gitlab.com/redhat/centos-stream/rpms/gnome-shell/-/blob/c9s/0001-welcomeDialog-Adapt-dialog-title.patch#L32). Can you help us?

Comment 22 errata-xmlrpc 2023-05-09 07:41:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (gnome-shell bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2280