SRPM: https://fedorapeople.org/~limb/review/CalcMySky/CalcMySky-0.1.0-1.fc37.src.rpm SPEC: https://fedorapeople.org/~limb/review/CalcMySky/CalcMySky.spec Description: CalcMySky is a software package that simulates scattering of light by the atmosphere to render daytime and twilight skies (without stars). Its primary purpose is to enable realistic view of the sky in applications such as planetaria. Secondary objective is to make it possible to explore atmospheric effects such as glories, fogbows etc., as well as simulate unusual environments such as on Mars or an exoplanet orbiting a star with a non-solar spectrum of radiation.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in CalcMySky-devel - Source0 could be simplified as %{url}/archive/v%{version}/%{name}-%{version}.tar.gz ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 139 files have unknown license. Detailed output of licensecheck in /home/rpmbuild/reviews/2131842-CalcMySky/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [?]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in CalcMySky-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=92661742 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 CalcMySky-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/CalcMySky-0.1.0-1.fc38.x86_64 CalcMySky-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/calcmysky-0.1.0-1.fc38.x86_64.debug CalcMySky-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/showmysky-0.1.0-1.fc38.x86_64.debug CalcMySky-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libShowMySky.so-0.1.0-1.fc38.x86_64.debug CalcMySky-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/CalcMySky-0.1.0-1.fc38.x86_64 CalcMySky-devel.x86_64: W: only-non-binary-in-usr-lib CalcMySky.x86_64: W: no-manual-page-for-binary calcmysky CalcMySky.x86_64: W: no-manual-page-for-binary showmysky CalcMySky-debugsource.x86_64: W: no-documentation CalcMySky-devel.x86_64: W: no-documentation CalcMySky-debuginfo.x86_64: W: no-documentation CalcMySky-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/CalcMySky-0.1.0-1.fc38.x86_64 CalcMySky-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/calcmysky-0.1.0-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/calcmysky-0.1.0-1.fc38.x86_64.debug' CalcMySky-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/bin/showmysky-0.1.0-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/bin/showmysky-0.1.0-1.fc38.x86_64.debug' CalcMySky-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib64/libShowMySky.so-0.1.0-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib64/libShowMySky.so-0.1.0-1.fc38.x86_64.debug' CalcMySky.x86_64: E: invalid-soname /usr/lib64/libShowMySky.so libShowMySky.so CalcMySky-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz CalcMySky-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz CalcMySky-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/4c/4946c04b6830235cbb03f1e2cbf772fbed4db2 ../../../.build-id/4c/4946c04b6830235cbb03f1e2cbf772fbed4db2 CalcMySky-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/4d/f65bf59fc632679ed3085da2f4dfa31dc529ad ../../../.build-id/4d/f65bf59fc632679ed3085da2f4dfa31dc529ad CalcMySky-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/65/c9352dab16e8b1f85fe08b6d65e14d559cdc15 ../../../.build-id/65/c9352dab16e8b1f85fe08b6d65e14d559cdc15 4 packages and 0 specfiles checked; 6 errors, 15 warnings, 6 badness; has taken 1.9 s Unversioned so-files -------------------- CalcMySky: /usr/lib64/libShowMySky.so Source checksums ---------------- https://github.com/10110111/CalcMySky/archive/v0.1.0/CalcMySky-0.1.0.tar.gz : CHECKSUM(SHA256) this package : 830f0332facc6ba5e45b9e7c4791346d32ec1af5a881d203c01700bd8802cb20 CHECKSUM(SHA256) upstream package : 830f0332facc6ba5e45b9e7c4791346d32ec1af5a881d203c01700bd8802cb20 Requires -------- CalcMySky (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) CalcMySky-devel (rpmlib, GLIBC filtered): CalcMySky CalcMySky-debuginfo (rpmlib, GLIBC filtered): CalcMySky-debugsource (rpmlib, GLIBC filtered): Provides -------- CalcMySky: CalcMySky CalcMySky(x86-64) libShowMySky.so()(64bit) CalcMySky-devel: CalcMySky-devel CalcMySky-devel(x86-64) CalcMySky-debuginfo: CalcMySky-debuginfo CalcMySky-debuginfo(x86-64) debuginfo(build-id) libShowMySky.so-0.1.0-1.fc38.x86_64.debug()(64bit) CalcMySky-debugsource: CalcMySky-debugsource CalcMySky-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2131842 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: PHP, Python, SugarActivity, Perl, Java, Ocaml, Haskell, R, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
I've added %{?_isa} to the -devel Requires, anything else?
(In reply to Gwyn Ciesla from comment #2) > I've added %{?_isa} to the -devel Requires, anything else? See the Issues section of my review. The shared library must be versioned https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning (`Under no circumstances should the unversioned library be shipped in Fedora`) and the COPYING file must be marked with `%license` instead of `%doc`.
SRPM: https://fedorapeople.org/~limb/review/CalcMySky/CalcMySky-0.1.0-2.fc37.src.rpm SPEC: https://fedorapeople.org/~limb/review/CalcMySky/CalcMySky.spec I've fixed the license file, and moved the .so to -devel with not impact on functionality.
(In reply to Gwyn Ciesla from comment #4) > moved the .so to -devel with not impact on functionality. mmm are you sure of that? Accordingly to the README: `libShowMySky library that lets the applications render the atmosphere model` so the library is needed by other programs directly at runtime, not at build time. That means that, for example, stellarium will have to Require: CalcMySky-devel which is bad. I've proposed a PR to upstream to set the soname on the library (https://github.com/10110111/CalcMySky/pull/8), let's see if they accept. Everything else in the specfile looks fine.
Upstream accepted my patch, I therefore mark the review ACCEPTED, provided that you package the latest git commit or backport that patch and put libShowMySky.so in -devel and libShowMySky.so.0{,.*} in the main package (remember to not glob the soname major version - https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files ).
Wonderful, will do, thank you so much!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/CalcMySky