Bug 2132123 - Combine all certbot packages
Summary: Combine all certbot packages
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: certbot
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Bebout
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-04 16:26 UTC by Jonathan Wright
Modified: 2023-03-20 19:21 UTC (History)
9 users (show)

Fixed In Version: certbot-2.2.0-1.fc39
Clone Of:
Environment:
Last Closed: 2023-03-20 19:21:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jonathan Wright 2022-10-04 16:26:03 UTC
I think we should combine all of the certbot packages to build from a single source/spec.  We can get all sources in one package from upstream since they're all in a single git repo at https://github.com/certbot/certbot

Having them split up only increases the workload required to release updates on packagers and it's also unnecessary load on build servers.

The only downside I can think of is cases where dependencies of some of the modules might not be available for new Fedora/EPEL releases yet (or if deps in a certain certbot plugin get updated) and would hold back the whole release over a single sub-package/certbot plugin missing a dep but I think the logical thing in that case is comment out the building of said package from the spec until a time when the dep issue is resolved.

I'm happy to put in the work to convert the current spec if other packagers/SIG members are on board with this change.

Comment 1 Felix Schwarz 2022-10-05 19:32:17 UTC
If you are willing to work on that I'm ok with this.

Btw: There is a collection of scripts (originally started by Eli) which automate much of the update process: https://github.com/FelixSchwarz/fedpkgscripts
Not sure how you did the last updates but if you did all of that manually the scripts can reduce the amount of work quite a bit.

Comment 2 Jonathan Wright 2022-11-24 00:45:13 UTC
I'm making some headway on this.  Here's a partial spec (only covers certbot, python3-acme, python-acme-doc, and python3-certbot-apache) if anyone has any advice/feedback.

https://jonathanspw.fedorapeople.org/certbot.spec

Comment 3 Jonathan Wright 2023-02-01 17:08:52 UTC
PR submitted, now everyone tear it apart and tell me how to make it better.

https://src.fedoraproject.org/rpms/certbot/pull-request/7

Comment 4 Ben Cotton 2023-02-07 14:56:51 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 38 development cycle.
Changing version to 38.

Comment 5 Jonathan Wright 2023-02-14 22:54:08 UTC
Any feedback on the PR?

Comment 6 Fedora Update System 2023-03-20 19:18:25 UTC
FEDORA-2023-ecbfdf9d0c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ecbfdf9d0c

Comment 7 Fedora Update System 2023-03-20 19:21:03 UTC
FEDORA-2023-ecbfdf9d0c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.