Spec URL: https://stansoft.sourceforge.net/dl/stansoft.spec SRPM URL: https://stansoft.sourceforge.net/dl/stansoft-8.1-1.fc36.src.rpm Description: Stansoft is a comprehensive double-entry financial accounting system. It includes payroll for both the U.S. and UK. It is HMRC-recognised for UK PAYE RTI payroll and MTD VAT returns. Fedora Account System Username: stansoft
Thanks for submitting the package. AUBIT4GL should be compiled as a separate package, and not bundled: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
There is a pending review for Aubit4gl https://bugzilla.redhat.com/show_bug.cgi?id=2119494
The link you gave does not say it is forbidden to bundle and since a Fedora package of Aubit4GL does not exist, would it be acceptable to bundle in this case?
No, some later package may use Aubit4GL. Unless there are heavy modifications, bundling is discouraged and usually needs an exception.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06565805-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06565805-stansoft/stansoft-8.5-1.fc40.src.rpm Packaged with the system aubit4gl rpm package
Copr build: https://copr.fedorainfracloud.org/coprs/build/6565820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06565820-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.