Spec URL: https://stansoft.sourceforge.net/dl/stansoft.spec SRPM URL: https://stansoft.sourceforge.net/dl/stansoft-8.1-1.fc36.src.rpm Description: Stansoft is a comprehensive double-entry financial accounting system. It includes payroll for both the U.S. and UK. It is HMRC-recognised for UK PAYE RTI payroll and MTD VAT returns. Fedora Account System Username: stansoft
Thanks for submitting the package. AUBIT4GL should be compiled as a separate package, and not bundled: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
There is a pending review for Aubit4gl https://bugzilla.redhat.com/show_bug.cgi?id=2119494
The link you gave does not say it is forbidden to bundle and since a Fedora package of Aubit4GL does not exist, would it be acceptable to bundle in this case?
No, some later package may use Aubit4GL. Unless there are heavy modifications, bundling is discouraged and usually needs an exception.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06565805-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06565805-stansoft/stansoft-8.5-1.fc40.src.rpm Packaged with the system aubit4gl rpm package
Copr build: https://copr.fedorainfracloud.org/coprs/build/6565820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06565820-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06784377-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06784377-stansoft/stansoft-8.6-1.fc40.src.rpm
Created attachment 2005572 [details] The .spec file difference from Copr build 6565820 to 6784939
Copr build: https://copr.fedorainfracloud.org/coprs/build/6784939 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06784939-stansoft/fedora-review/review.txt Found issues: - Documentation size is 2257793 bytes in 9 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06982634-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06982634-stansoft/stansoft-9.0-1.fc40.src.rpm
Created attachment 2014702 [details] The .spec file difference from Copr build 6784939 to 6982660
Copr build: https://copr.fedorainfracloud.org/coprs/build/6982660 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06982660-stansoft/fedora-review/review.txt Found issues: - Documentation size is 2311642 bytes in 9 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06983644-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06983644-stansoft/stansoft-9.0-1.fc40.src.rpm
Created attachment 2014839 [details] The .spec file difference from Copr build 6982660 to 6983939
Copr build: https://copr.fedorainfracloud.org/coprs/build/6983939 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06983939-stansoft/fedora-review/review.txt Found issues: - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/stansoft/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06984033-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06984033-stansoft/stansoft-9.0-1.fc40.src.rpm
Created attachment 2014854 [details] The .spec file difference from Copr build 6983939 to 6984037
Copr build: https://copr.fedorainfracloud.org/coprs/build/6984037 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06984037-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
rpmlint has error 'explicit-lib-dependency libpq' It has a false-positive on anything with lib in the package name. See https://bugzilla.redhat.com/show_bug.cgi?id=790869 Package libpq is required at runtime. It also has warnings on non-standard-uid, non-standard-gid /var/lib/stansoft User stansoft owns the PostgreSQL database so must own this directory. %{SOURCE2} is set as stansoft.rpmlintrc which includes rpmlint filters, but how can Copr be told to use this file when running rpmlint? #stansoft.rpmlintrc addFilter('explicit-lib-dependency libpq') addFilter('non-standard-uid /var/lib/stansoft stansoft') addFilter('non-standard-gid /var/lib/stansoft stansoft')
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/07198661-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/07198661-stansoft/stansoft-9.1-1.fc41.src.rpm Updated the Stansoft version, this package still is in need of a review if anyone wants to take it.
Created attachment 2023059 [details] The .spec file difference from Copr build 6984037 to 7198693
Copr build: https://copr.fedorainfracloud.org/coprs/build/7198693 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/07198693-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/08482782-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-41-x86_64/08482782-stansoft/stansoft-10.0-1.fc41.src.rpm Updated the Stansoft version
You may not set fedora-review flag on your own submission. Only a reviewer may set it.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
Hi, I am looking at this package and nobody has looked at it in some time. * Issue: philwyett @ ks-kenobi ~/Development/build >> spectool -g -R stansoft.spec Downloading: https://download.stansoft.org/files/stansoft-10.0.tar.bz2 Download failed: 404 Client Error: Not Found for url: https://download.stansoft.org/files/stansoft-10.0.tar.bz2 Downloading: https://download.stansoft.org/files/stansoft.1.gz Download failed: 404 Client Error: Not Found for url: https://download.stansoft.org/files/stansoft.1.gz Downloading: https://download.stansoft.org/files/stansoft.rpmlintrc Download failed: 404 Client Error: Not Found for url: https://download.stansoft.org/files/stansoft.rpmlintrc * 'BuildRequires' should be before 'Requires'. * '%prep', should really be using '%autosetup'. * Remove lines that are commented out that are no longer needed. * '%files'. After '%license' and '%doc' elements, all other elements are best in alphabetical order. Build: Fails to build on many architectures, see link below. https://copr.fedorainfracloud.org/coprs/kathenas/generic-fedora-rawhide-all-with-review-not-production/build/10171548/ Regards Phil
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/10172562-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/10172562-stansoft/stansoft-11.0-1.fc45.src.rpm Updated Stansoft version and fixup to rpm spec
It only builds on x86_64 and aarch64 as that is all that is required by Fedora. Should I add ExclusiveArch: i686 x86_64 ?
I meant to write: ExclusiveArch: x86_64 aarch64 or I could add ExcludeArch: i686 s390x ppc64le
(In reply to Stansoft from comment #29) > I meant to write: ExclusiveArch: x86_64 aarch64 or I could add ExcludeArch: > i686 s390x ppc64le I would be more inclined to go with 'ExclusiveArch'.
This is the first time the package would be in Fedora, so I would drop all %changelog entries but the latest as the initial RPM packaging.
(In reply to Phil Wyett from comment #30) > (In reply to Stansoft from comment #29) > > I meant to write: ExclusiveArch: x86_64 aarch64 or I could add ExcludeArch: > > i686 s390x ppc64le > > I would be more inclined to go with 'ExclusiveArch'. Once this update is uploaded, I shall do a fuller review. Regards Phil
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/10175609-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/10175609-stansoft/stansoft-11.0-1.fc45.src.rpm The requested changes have been made.
Created attachment 2131361 [details] The .spec file difference from Copr build 8482809 to 10178460
Copr build: https://copr.fedorainfracloud.org/coprs/build/10178460 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/10178460-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Stansoft, * Is the below line for removal in this spec file also? %global aubit4glver %(rpm -q --qf '%%{VERSION}' aubit4gl | cut -d. -f1-3) * Build looks good, see link below. https://copr.fedorainfracloud.org/coprs/kathenas/generic-fedora-rawhide-all-with-review-not-production/build/10179286/ Running package - Not strictly in review... Running 'stansoft' gives the below. philwyett@ks-c3po:~/Downloads$ stansoft psql: error: connection to server on socket "/tmp/.s.PGSQL.5432" failed: No such file or directory Is the server running locally and accepting connections on that socket? If you are using the system installed PostgreSQL package, set PGDIR=/usr/lib/postgresql/14 to the exec prefix of the psql command. If you receive an error that a role does not exist, you must add the new user with user stansoft The PostgreSQL database server may not be running. Start it by running "/usr/lib64/stansoft/etc/rc.postgresql start" or "systemctl start stansoft" If you are using Informix then you must set INFORMIXDIR Example: export INFORMIXDIR=/opt/informix If this is a new install, run "/usr/lib64/stansoft/installss" to initialize and create the database. This will create the database in directory "/var/lib/stansoft/data" philwyett@ks-c3po:~/Downloads$ This seems quite user unfriendly of what to do first and what follows. Regards Phil
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/10179484-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/10179484-stansoft/stansoft-11.0-1.fc45.src.rpm I removed the unused aubit4glver variable You need to run the script /usr/lib64/stansoft/installss. I will make this more clear in the next release.
Created attachment 2131430 [details] The .spec file difference from Copr build 10178460 to 10179948
Copr build: https://copr.fedorainfracloud.org/coprs/build/10179948 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/10179948-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Stansoft, With regard packaging, looks good and I am marking as '+'. As with all packages, improvements are made moving forward. To get sponsorship, you will now need to create a ticket at the link below. https://pagure.io/packager-sponsors/issues Extra info: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/ User experience... As far as user experience goes, there is much to do with clear initial setup and on. I leave you to approach this in your own time and way. Regards Phil
Thank you for doing the review.
Apologies, Ypu are a 'packager' so should have done this to create repo.
You can now request repo etc. Regards Phil
The Pagure repository was created at https://src.fedoraproject.org/rpms/stansoft