Spec URL: https://stansoft.sourceforge.net/dl/stansoft.spec SRPM URL: https://stansoft.sourceforge.net/dl/stansoft-8.1-1.fc36.src.rpm Description: Stansoft is a comprehensive double-entry financial accounting system. It includes payroll for both the U.S. and UK. It is HMRC-recognised for UK PAYE RTI payroll and MTD VAT returns. Fedora Account System Username: stansoft
Thanks for submitting the package. AUBIT4GL should be compiled as a separate package, and not bundled: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
There is a pending review for Aubit4gl https://bugzilla.redhat.com/show_bug.cgi?id=2119494
The link you gave does not say it is forbidden to bundle and since a Fedora package of Aubit4GL does not exist, would it be acceptable to bundle in this case?
No, some later package may use Aubit4GL. Unless there are heavy modifications, bundling is discouraged and usually needs an exception.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06565805-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06565805-stansoft/stansoft-8.5-1.fc40.src.rpm Packaged with the system aubit4gl rpm package
Copr build: https://copr.fedorainfracloud.org/coprs/build/6565820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06565820-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06784377-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06784377-stansoft/stansoft-8.6-1.fc40.src.rpm
Created attachment 2005572 [details] The .spec file difference from Copr build 6565820 to 6784939
Copr build: https://copr.fedorainfracloud.org/coprs/build/6784939 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06784939-stansoft/fedora-review/review.txt Found issues: - Documentation size is 2257793 bytes in 9 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06982634-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06982634-stansoft/stansoft-9.0-1.fc40.src.rpm
Created attachment 2014702 [details] The .spec file difference from Copr build 6784939 to 6982660
Copr build: https://copr.fedorainfracloud.org/coprs/build/6982660 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06982660-stansoft/fedora-review/review.txt Found issues: - Documentation size is 2311642 bytes in 9 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06983644-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06983644-stansoft/stansoft-9.0-1.fc40.src.rpm
Created attachment 2014839 [details] The .spec file difference from Copr build 6982660 to 6983939
Copr build: https://copr.fedorainfracloud.org/coprs/build/6983939 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06983939-stansoft/fedora-review/review.txt Found issues: - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/stansoft/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06984033-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/06984033-stansoft/stansoft-9.0-1.fc40.src.rpm
Created attachment 2014854 [details] The .spec file difference from Copr build 6983939 to 6984037
Copr build: https://copr.fedorainfracloud.org/coprs/build/6984037 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/06984037-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
rpmlint has error 'explicit-lib-dependency libpq' It has a false-positive on anything with lib in the package name. See https://bugzilla.redhat.com/show_bug.cgi?id=790869 Package libpq is required at runtime. It also has warnings on non-standard-uid, non-standard-gid /var/lib/stansoft User stansoft owns the PostgreSQL database so must own this directory. %{SOURCE2} is set as stansoft.rpmlintrc which includes rpmlint filters, but how can Copr be told to use this file when running rpmlint? #stansoft.rpmlintrc addFilter('explicit-lib-dependency libpq') addFilter('non-standard-uid /var/lib/stansoft stansoft') addFilter('non-standard-gid /var/lib/stansoft stansoft')
Spec URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/07198661-stansoft/stansoft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/stansoft/Stansoft/fedora-rawhide-x86_64/07198661-stansoft/stansoft-9.1-1.fc41.src.rpm Updated the Stansoft version, this package still is in need of a review if anyone wants to take it.
Created attachment 2023059 [details] The .spec file difference from Copr build 6984037 to 7198693
Copr build: https://copr.fedorainfracloud.org/coprs/build/7198693 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2133482-stansoft/fedora-rawhide-x86_64/07198693-stansoft/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.