Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2133781

Summary:	pep8 job fails due to bad indentations after new bashate release
Product:	Red Hat OpenStack	Reporter:	Szymon Datko <sdatko>
Component:	openstack-ironic	Assignee:	Harald Jensås <hjensas>
Status:	CLOSED ERRATA	QA Contact:
Severity:	medium	Docs Contact:
Priority:	high
Version:	17.0 (Wallaby)	CC:	hjensas, jparoly, pweeks, sbaker
Target Milestone:	z1	Keywords:	Triaged
Target Release:	17.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-ironic-17.0.5-0.20221018210642.dd2bfab.el9ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-01-25 12:29:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Szymon Datko 2022-10-11 11:29:07 UTC

Hello,

starting last week, the pep8 tox job for ironic project is failing with the following error:
```
2022-10-08 12:32:12.601134 | container | ./devstack/lib/ironic:1853:1: E002 Tab indents
2022-10-08 12:32:12.601141 | container | ./devstack/lib/ironic:1853:1: E003 Indent not multiple of 4
2022-10-08 12:32:12.601147 | container | ./devstack/lib/ironic:1854:1: E002 Tab indents
2022-10-08 12:32:12.601153 | container | ./devstack/lib/ironic:1854:1: E003 Indent not multiple of 4
2022-10-08 12:32:12.601160 | container | ./devstack/lib/ironic:1855:1: E002 Tab indents
2022-10-08 12:32:12.601166 | container | ./devstack/lib/ironic:1855:1: E003 Indent not multiple of 4
2022-10-08 12:32:12.601171 | container | ./devstack/lib/ironic:1856:1: E002 Tab indents
2022-10-08 12:32:12.601180 | container | ./devstack/lib/ironic:1856:1: E003 Indent not multiple of 4
```

This is bacause bashate is specified in tox.ini (https://code.engineering.redhat.com/gerrit/gitweb?p=ironic.git;a=blob;f=tox.ini;h=d72f30c29e37012f929c5a2a6075c1c01355600d;hb=refs/heads/rhos-17.0-trunk-patches#l41) with only lower constraint and it does not reference upper-contraints.txt file for the pep8 tox environment.

With recent release of Bashate===2.1.1 (https://pypi.org/project/bashate/#history) the following commit was included in the tool and it causes the failures
https://opendev.org/openstack/bashate/commit/0feb84a83fca92789d2a154b33b959ef6ffbff11

Proposed solutions:
– fix the devstack/lib/ironic file
– pin the bashate version

This affects Component CI jobs for OSP 17 and OSP 17.1, but maybe also upstream stable/wallaby (I didn't check).

Yours, Szymon

Comment 1 Harald Jensås 2022-10-11 18:07:24 UTC

I see the same errors in the upstream stable/wallaby. stable/xena is fine.

Comment 3 Szymon Datko 2022-10-18 12:41:22 UTC

Just to confirm, I can see both changes were merged and today the red markers are gone from CRE monitoring page :-)

Comment 14 errata-xmlrpc 2023-01-25 12:29:56 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 17.0.1 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:0271