Bug 2133977 - [REGRESSION][BISECTED] Amdgpu: Choppy videos and desktop effect when moving mouse
Summary: [REGRESSION][BISECTED] Amdgpu: Choppy videos and desktop effect when moving m...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: rawhide
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-12 03:08 UTC by Robert-André Mauchin 🐧
Modified: 2023-08-02 20:38 UTC (History)
18 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-02 20:38:27 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
journalctl -b 2 -k (134.72 KB, text/plain)
2022-10-12 03:08 UTC, Robert-André Mauchin 🐧
no flags Details

Description Robert-André Mauchin 🐧 2022-10-12 03:08:44 UTC
Created attachment 1917425 [details]
journalctl -b 2 -k

1. Please describe the problem:
When playing videos with mpv and Firefox, or when using desktop effects (Plasma Workspaces with kwin X11), moving the mouse results in frames drop, almost freezing the video.

2. What is the Version-Release number of the kernel:
Kernel 5.19.12 and later (including 6.x.x)


3. Did it work previously in Fedora? If so, what kernel version did the issue
   *first* appear?  Old kernels are available for download at
   https://koji.fedoraproject.org/koji/packageinfo?packageID=8 :

It worked on 5.19.11.


4. Can you reproduce this issue? If so, please provide the steps to reproduce
   the issue below:

Yes, launch a video in mpv and move the mouse: frames drop guaranteed.


5. Does this problem occur with the latest Rawhide kernel? To install the
   Rawhide kernel, run ``sudo dnf install fedora-repos-rawhide`` followed by
   ``sudo dnf update --enablerepo=rawhide kernel``:

Yes.

6. Are you running any modules that not shipped with directly Fedora's kernel?:

No.


Environment: Fedora 37 Beta
KWin 5.25.5
Mesa 22.2.0 (rebuilt with acceleration for patented codec)

VAinfo:

libva info: VA-API version 1.15.0
libva info: Trying to open /usr/lib64/dri/radeonsi_drv_video.so
libva info: Found init function __vaDriverInit_1_15
libva info: va_openDriver() returns 0
vainfo: VA-API version: 1.15 (libva 2.15.0)
vainfo: Driver version: Mesa Gallium driver 22.2.0 for RENOIR (renoir, LLVM 15.0.0, DRM 3.47, 5.19.11-300.fc37.git444574f.x86_64)
vainfo: Supported profile and entrypoints
      VAProfileMPEG2Simple            : VAEntrypointVLD
      VAProfileMPEG2Main              : VAEntrypointVLD
      VAProfileVC1Simple              : VAEntrypointVLD
      VAProfileVC1Main                : VAEntrypointVLD
      VAProfileVC1Advanced            : VAEntrypointVLD
      VAProfileH264ConstrainedBaseline: VAEntrypointVLD
      VAProfileH264ConstrainedBaseline: VAEntrypointEncSlice
      VAProfileH264Main               : VAEntrypointVLD
      VAProfileH264Main               : VAEntrypointEncSlice
      VAProfileH264High               : VAEntrypointVLD
      VAProfileH264High               : VAEntrypointEncSlice
      VAProfileHEVCMain               : VAEntrypointVLD
      VAProfileHEVCMain               : VAEntrypointEncSlice
      VAProfileHEVCMain10             : VAEntrypointVLD
      VAProfileHEVCMain10             : VAEntrypointEncSlice
      VAProfileJPEGBaseline           : VAEntrypointVLD
      VAProfileVP9Profile0            : VAEntrypointVLD
      VAProfileVP9Profile2            : VAEntrypointVLD
      VAProfileNone                   : VAEntrypointVideoProc


Hardware:

ASUS ROG Zephyrus G15 2021
AMD Ryzen 9 5900HS with Radeon Graphics
NVIDIA dGPU disabled entirely


hwinfo --gfxcard
18: PCI 700.0: 0300 VGA compatible controller (VGA)             
  [Created at pci.386]
  Unique ID: aK5u.M8Q6IVfm5T4
  Parent ID: JZZT.e+TNXSUNut3
  SysFS ID: /devices/pci0000:00/0000:00:08.1/0000:07:00.0
  SysFS BusID: 0000:07:00.0
  Hardware Class: graphics card
  Model: "ATI Cezanne"
  Vendor: pci 0x1002 "ATI Technologies Inc"
  Device: pci 0x1638 "Cezanne"
  SubVendor: pci 0x1043 "ASUSTeK Computer Inc."
  SubDevice: pci 0x1622 
  Revision: 0xc4
  Driver: "amdgpu"
  Driver Modules: "amdgpu"
  Memory Range: 0xfc10000000-0xfc1fffffff (ro,non-prefetchable)
  Memory Range: 0xfc20000000-0xfc201fffff (ro,non-prefetchable)
  I/O Ports: 0xc000-0xc0ff (rw)
  Memory Range: 0xfc500000-0xfc57ffff (rw,non-prefetchable)
  IRQ: 48 (no events)
  Module Alias: "pci:v00001002d00001638sv00001043sd00001622bc03sc00i00"
  Driver Info #0:
    Driver Status: amdgpu is active
    Driver Activation Cmd: "modprobe amdgpu"
  Config Status: cfg=new, avail=yes, need=no, active=unknown
  Attached to: #22 (PCI bridge)

Primary display adapter: #18

hwinfo --cpu
01: None 00.0: 10103 CPU                                        
  [Created at cpu.462]
  Unique ID: rdCR.j8NaKXDZtZ6
  Hardware Class: cpu
  Arch: X86-64
  Vendor: "AuthenticAMD"
  Model: 25.80.0 "AMD Ryzen 9 5900HS with Radeon Graphics"
  Features: fpu,vme,de,pse,tsc,msr,pae,mce,cx8,apic,sep,mtrr,pge,mca,cmov,pat,pse36,clflush,mmx,fxsr,sse,sse2,ht,syscall,nx,mmxext,fxsr_opt,pdpe1gb,rdtscp,lm,constant_tsc,rep_good,nopl,nonstop_tsc,cpuid,extd_apicid,aperfmperf,rapl,pni,pclmulqdq,monitor,ssse3,fma,cx16,sse4_1,sse4_2,movbe,popcnt,aes,xsave,avx,f16c,rdrand,lahf_lm,cmp_legacy,svm,extapic,cr8_legacy,abm,sse4a,misalignsse,3dnowprefetch,osvw,ibs,skinit,wdt,tce,topoext,perfctr_core,perfctr_nb,bpext,perfctr_llc,mwaitx,cpb,cat_l3,cdp_l3,hw_pstate,ssbd,mba,ibrs,ibpb,stibp,vmmcall,fsgsbase,bmi1,avx2,smep,bmi2,erms,invpcid,cqm,rdt_a,rdseed,adx,smap,clflushopt,clwb,sha_ni,xsaveopt,xsavec,xgetbv1,xsaves,cqm_llc,cqm_occup_llc,cqm_mbm_total,cqm_mbm_local,clzero,irperf,xsaveerptr,rdpru,wbnoinvd,cppc,arat,npt,lbrv,svm_lock,nrip_save,tsc_scale,vmcb_clean,flushbyasid,decodeassists,pausefilter,pfthreshold,avic,v_vmsave_vmload,vgif,v_spec_ctrl,umip,pku,ospke,vaes,vpclmulqdq,rdpid,overflow_recov,succor,smca,fsrm
  Clock: 400 MHz
  BogoMips: 6587.55
  Cache: 512 kb
  Units/Processor: 16
  Config Status: cfg=new, avail=yes, need=no, active=unknown


7. Please attach the kernel logs. You can get the complete kernel log
   for a boot with ``journalctl --no-hostname -k > dmesg.txt``. If the
   issue occurred on a previous boot, use the journalctl ``-b`` flag.

Done.


Bisection:

Since the changes affecting amdgpu were fairly limited between 5.19.11 and 5.19.12, I was able to bisect the problem to this commit:

8442bc8426d1264496468066498b196aef5453a7 is the first bad commit
commit 8442bc8426d1264496468066498b196aef5453a7
Author: Hamza Mahfooz <hamza.mahfooz>
Date:   Tue Sep 6 15:01:49 2022 -0400

    drm/amdgpu: use dirty framebuffer helper
    
    [ Upstream commit 66f99628eb24409cb8feb5061f78283c8b65f820 ]
    
    Currently, we aren't handling DRM_IOCTL_MODE_DIRTYFB. So, use
    drm_atomic_helper_dirtyfb() as the dirty callback in the amdgpu_fb_funcs
    struct.
    
    Signed-off-by: Hamza Mahfooz <hamza.mahfooz>
    Acked-by: Alex Deucher <alexander.deucher>
    Signed-off-by: Alex Deucher <alexander.deucher>
    Signed-off-by: Sasha Levin <sashal>

 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 ++
 1 file changed, 2 insertions(+)

Comment 1 Robert-André Mauchin 🐧 2022-10-12 03:42:37 UTC
It seems there is a patch in the works to revert that commit: https://lore.kernel.org/all/20221005154719.57566-1-hamza.mahfooz@amd.com/t/#e0255a32f73cb2735c07a2f7821850bec2c0f3b6b


Note You need to log in before you can comment on or make changes to this bug.