Bug 213525 - NetworkManager is core dumping on an error condition
Summary: NetworkManager is core dumping on an error condition
Alias: None
Product: Fedora
Classification: Fedora
Component: NetworkManager   
(Show other bugs)
Version: 6
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Dan Williams
QA Contact:
Whiteboard: bzcl34nup
Depends On:
TreeView+ depends on / blocked
Reported: 2006-11-01 20:22 UTC by Jeff Law
Modified: 2008-05-06 16:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2008-05-06 16:39:41 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
close stream iff it is non-null on error (549 bytes, patch)
2006-11-01 20:22 UTC, Jeff Law
no flags Details | Diff

Description Jeff Law 2006-11-01 20:22:22 UTC
Description of problem:
NetworkManager core dumps if the root filesystem is read-only due to incorrect
handling of errors when updating /etc/resolv.conf.

Version-Release number of selected component (if applicable):
FC6, probably all others.

How reproducible:
Allow NetworkManager to bring up an interface on a system with a readonly root

In nm-named-manager.c::rewrite_resolv_conf we try to fopen a temporary file to
hold the new contents for /etc/resolv.conf.  If that fopen fails "f" will be set
to NULL and we "goto lose" to gracefully handle the error condition.

Unfortunately, the error handling code blindly does an "fclose (f)", which will
core dump if "f" is NULL.

The right thing to do is close the stream if and only if it is non-NULL.

Steps to Reproduce:
Actual results:

Expected results:

Additional info:

Comment 1 Jeff Law 2006-11-01 20:22:22 UTC
Created attachment 140031 [details]
close stream iff it is non-null on error

Comment 2 Bug Zapper 2008-04-04 04:20:21 UTC
Fedora apologizes that these issues have not been resolved yet. We're
sorry it's taken so long for your bug to be properly triaged and acted
on. We appreciate the time you took to report this issue and want to
make sure no important bugs slip through the cracks.

If you're currently running a version of Fedora Core between 1 and 6,
please note that Fedora no longer maintains these releases. We strongly
encourage you to upgrade to a current Fedora release. In order to
refocus our efforts as a project we are flagging all of the open bugs
for releases which are no longer maintained and closing them.

If this bug is still open against Fedora Core 1 through 6, thirty days
from now, it will be closed 'WONTFIX'. If you can reporduce this bug in
the latest Fedora version, please change to the respective version. If
you are unable to do this, please add a comment to this bug requesting
the change.

Thanks for your help, and we apologize again that we haven't handled
these issues to this point.

The process we are following is outlined here:

We will be following the process here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping to ensure this
doesn't happen again.

And if you'd like to join the bug triage team to help make things
better, check out http://fedoraproject.org/wiki/BugZappers

Comment 3 Bug Zapper 2008-05-06 16:39:39 UTC
This bug is open for a Fedora version that is no longer maintained and
will not be fixed by Fedora. Therefore we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen thus bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Note You need to log in before you can comment on or make changes to this bug.