Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2135768

Summary:	RHEL 9.2: Rebase virt-top to the latest version
Product:	Red Hat Enterprise Linux 9	Reporter:	Richard W.M. Jones <rjones>
Component:	virt-top	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED ERRATA	QA Contact:	Hongzhou Liu <hongzliu>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.2	CC:	chhu, hongzliu, juzhou, mxie, rjones, tyan, tzheng, virt-maint, vwu, xiaodwan
Target Milestone:	rc	Keywords:	Rebase, Triaged
Target Release:	---	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	virt-top-1.1.1-6.el9	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-05-09 07:37:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2022-10-18 11:32:15 UTC

Description of problem:

This is a general rebase bug to rebase virt-top to the latest stable
version in RHEL 9.2.

The plan for RHEL 9.2 is here:
https://lists.corp.redhat.com/archives/v2v-devel/2022-August/000028.html

Comment 1 John Ferlan 2022-10-18 12:00:50 UTC

Setting ITR=9.2.0 and DTM=15 just to give a target. 

This needs to be completed before 15-Jan in order to be ready for Comprehensive Test Cycle 2

Comment 2 Richard W.M. Jones 2022-10-18 13:20:42 UTC

Juquin, can you consider QE for this?  The changes to the program
are unfortunately quite large, because I removed dependencies on
3 OCaml packages which meant large internal rewrites.  The visible
functionality should not be any different.

Here is the change log between versions:

commit 6a45c04e27b942555e79f96f52e452e56d1aca97 (HEAD -> master, tag: v1.1.1, origin/master, origin/HEAD)
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 20:20:53 2021 +0000

    Version 1.1.1.

commit 042706796c00adaaadbd0f01b0fa48357a8927aa
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 20:11:07 2021 +0000

    src/collect.ml: Don't die if a domain goes away during lookup
    
    libvirt: VIR_ERR_NO_DOMAIN: VIR_FROM_QEMU: Domain not found: no domain with matching uuid '231eb609-fe6c-4de5-abbc-e1f834457c37'
    Raised by primitive operation at Libvirt in file "libvirt.ml" (inlined), line 573, characters 0-1023
    Called from Collect.collect.(fun) in file "collect.ml", line 168, characters 18-44
    Called from Stdlib__List.map in file "list.ml", line 92, characters 20-23
    Called from Stdlib__List.map in file "list.ml", line 92, characters 32-39
    Called from Collect.collect in file "collect.ml", line 138, characters 4-1023
    Called from Top.main_loop in file "top.ml", line 318, characters 16-29
    Called from Main in file "main.ml", line 50, characters 4-19

commit 5937a2ef820c7a0ddc4039202c0509a6fd52583d
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 19:24:22 2021 +0000

    Remove dependency on xml-light, replace with libxml2
    
    This commit removes the dependency on the ancient and dead upstream
    xml-light light.  It is replaced with the C library libxml2.  This
    introduces a small amount of C code to interface with libxml2 and
    parse the libvirt domain XML into the list of block devices and
    network devices (using XPath).

commit b8a058e62e65b4c7bd0b387d979d503b3d7f2543
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 19:59:22 2021 +0000

    build: Remove bogus directory list in ocaml-dep.sh.in
    
    This was a cut and paste error when I copied this file over from
    libguestfs.
    
    Fixes: commit 5405de2920fa56529b56f61ff683806e72ddfa6a

commit 42de3812f0bd97c3fa5114b39d9bb23c483d364b
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 11:28:58 2021 +0000

    Remove external dependency on ocaml-csv
    
    We only used a tiny number of features from this library, and it is
    distributed under a compatible license so we might as well inline the
    function we need.

commit 1aedabd0caf7a0562a3f314dddd13d49e0165c92
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 11:47:13 2021 +0000

    Remove dependency on ocaml-extlib
    
    We only used a handful of small functions from this library, so we can
    completely remove the dependency easily.

commit 4c608eef2274bc267d45d62550aafe2151514013
Author: Richard W.M. Jones <rjones>
Date:   Wed Nov 3 11:50:10 2021 +0000

    build: Use non-deprecated form of warning flags
    
    In OCaml 4.13:
    
    Alert ocaml_deprecated_cli: Setting a warning with a sequence of lowercase or uppercase letters,
    like 'CDEFLMPSUVYZX', is deprecated.
    Use the equivalent signed form: +C+D+E+F+L+M+P+S+U+V+Y+Z+X-3.

commit de67370c5b7c01e8dd7558348d8a11b4d7c4a21b
Merge: 521c3d7 01ab718
Author: Richard W.M. Jones <rjones>
Date:   Fri Oct 1 16:32:36 2021 +0100

    Merge remote-tracking branch 'weblate/master'

commit 521c3d78cdf7009c74e4fd9c4716fff91bcbc71e (tag: v1.1.0)
Author: Richard W.M. Jones <rjones>
Date:   Fri Oct 1 16:17:20 2021 +0100

    Version 1.1.0.
    
    Move to the more usual (for us) even = stable, odd = unstable
    semantic-ish versioning system, as used by olden days Linux.
    
    This is the first in a new development series.

commit 7b39eb2f4340321ca1504831eecf86535a3f57fd
Author: Richard W.M. Jones <rjones>
Date:   Fri Oct 1 16:16:29 2021 +0100

    Remove Changelog file
    
    Users can easily read the git logs if they want this information.

commit 90bf80103a6dd15fb2bba06e2e0b5d10e9ad713d
Author: Richard W.M. Jones <rjones>
Date:   Fri Oct 1 16:15:41 2021 +0100

    Remove old Zanata files
    
    We're meant to be using Weblate now.

commit 5405de2920fa56529b56f61ff683806e72ddfa6a
Author: Richard W.M. Jones <rjones>
Date:   Fri Oct 1 15:33:29 2021 +0100

    Convert to using automake

commit 01ab7183772e2b2a8a42a088d4521832577a0883 (weblate/master)
Author: Pavel Borecki <pavel.borecki>
Date:   Fri Oct 1 01:05:05 2021 +0200

    Translated using Weblate (Czech)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/cs/

commit 81db21bbe8da0855ab1f2fdb3158d52e6415bda1
Author: Didik Supriadi <didiksupriadi41>
Date:   Fri Oct 1 01:05:05 2021 +0200

    Translated using Weblate (Indonesian)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/id/

commit 293516074dda9e4fee76388b8ea795bf88a28cd7
Author: Andika Triwidada <andika>
Date:   Fri Oct 1 01:05:05 2021 +0200

    Translated using Weblate (Indonesian)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/id/

commit b14de1baf1028d1f3a3abc1deb07425e5bf50c66
Author: Jan Kuparinen <copper_fin>
Date:   Fri Oct 1 01:05:04 2021 +0200

    Translated using Weblate (Finnish)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/fi/
    
    Translated using Weblate (Finnish)
    
    Currently translated at 67.8% (57 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/fi/
    
    Added translation using Weblate (Finnish)

commit 6ab1c3efbf00237b9ddefdd4ecce612a7e899a69
Author: Hela Basa <r45xveza>
Date:   Fri Oct 1 01:05:04 2021 +0200

    Translated using Weblate (Sinhala)
    
    Currently translated at 1.1% (1 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/si/
    
    Added translation using Weblate (Sinhala)

commit 5952c3d099dc3254c454268e8b5da162b23946f9
Author: Geert Warrink <geert.warrink>
Date:   Fri Oct 1 01:05:04 2021 +0200

    Translated using Weblate (Dutch)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/nl/

commit e8444bbed83dfafecf4742a2e8632f97402b162c
Author: Emilio Herrera <ehespinosa57>
Date:   Fri Oct 1 01:05:04 2021 +0200

    Translated using Weblate (Spanish)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/es/
    
    Translated using Weblate (Spanish)
    
    Currently translated at 84.5% (71 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/es/

commit d76b7f021c17a2640a089f5473853849f4b32ec5
Merge: 4896834 5ea0889
Author: Richard W.M. Jones <rjones>
Date:   Mon Sep 21 08:36:38 2020 +0100

    Merge remote-tracking branch 'weblate/master' into master

commit 5ea088950a480621d60ae64a6ec3178bff918475
Author: Emilio Herrera <ehespinosa57>
Date:   Sat Sep 12 10:08:07 2020 +0000

    Translated using Weblate (Spanish)
    
    Currently translated at 84.5% (71 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/es/

commit 27e3db174122d340cd4daa6879ff48aa3705a692
Author: Julien Humbert <julroy67>
Date:   Fri Aug 28 05:29:18 2020 +0200

    Translated using Weblate (French)
    
    Currently translated at 20.2% (17 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/fr/

commit c5fa41d2122ecfdfcf1fef398e9b4a734fda5687
Author: Yuri Chornoivan <yurchor>
Date:   Fri Aug 28 05:29:18 2020 +0200

    Translated using Weblate (Ukrainian)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/uk/

commit d9e38c1743e9d81a336e88dfb1f02e1ad8fe9073
Author: Göran Uddeborg <goeran>
Date:   Fri Aug 28 05:29:17 2020 +0200

    Translated using Weblate (Swedish)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/sv/

commit 4dac6c41511c7425c18d53d375e7c574717d3256
Author: Oğuz Ersen <oguzersen>
Date:   Fri Aug 28 05:29:17 2020 +0200

    Translated using Weblate (Turkish)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/tr/

commit 1f3740cf211a4fd101d90dd10b777e41f0954092
Author: Piotr Drąg <piotrdrag>
Date:   Fri Aug 28 05:29:17 2020 +0200

    Translated using Weblate (Polish)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/pl/
    
    Translated using Weblate (Polish)
    
    Currently translated at 100.0% (84 of 84 strings)
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/pl/

commit 9c8d3ba8382df450392a8c78ab45fc263742096c
Author: Weblate <noreply>
Date:   Fri Aug 28 05:29:17 2020 +0200

    Update translation files
    
    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
    
    Translation: virt-top/master
    Translate-URL: https://translate.fedoraproject.org/projects/virt-top/master/

commit 4896834d28de56fa42ba0775b46a2968a4b947d9
Author: Richard W.M. Jones <rjones>
Date:   Thu Aug 27 08:37:51 2020 +0100

    Update translations from Zanata (RHBZ#1868108).

commit 24a461715d5bce47f63cb0097606fc336230589f
Author: Stephane Glondu <steph>
Date:   Wed Aug 21 17:24:47 2019 +0200

    libvirt: Handle VIR_DOMAIN_PMSUSPENDED state.
    
    Fixes FTBFS with ocaml-libvirt 0.6.1.5.
    
    RWMJ: Added documentation and changed the letter to 'M'.

Comment 3 Richard W.M. Jones 2022-10-18 13:22:36 UTC

Scratch build:
https://kojihub.stream.rdu2.redhat.com/koji/taskinfo?taskID=1509435

Comment 4 tingting zheng 2022-10-19 01:08:51 UTC

(In reply to Richard W.M. Jones from comment #3)
> Scratch build:
> https://kojihub.stream.rdu2.redhat.com/koji/taskinfo?taskID=1509435


Thanks for the scratch build, QE will go through the change in comment 2 and run some testing.

Comment 5 Hongzhou Liu 2022-11-11 01:35:17 UTC

Based on this test run, I add verified:tested to this bug 
https://polarion.engineering.redhat.com/polarion/#/project/RHELVIRT/testrun?id=virt-top-20221024 

Thanks

Comment 8 Hongzhou Liu 2023-02-10 02:53:44 UTC

Vierify this bug with Latest RHEL9.2

packages:

qemu-kvm-7.2.0-7.el9.x86_64
libvirt-9.0.0-3.el9.x86_64
virt-top-1.1.1-9.el9.x86_64

After go through all the commits in comment2. Based on this test run and reviewed recent virt-top bugs, bz2148798 and bz2159549
test run link: 
https://polarion.engineering.redhat.com/polarion/#/project/RHELVIRT/testrun?id=virt-top-20221024

I change status to VERIFIED, Thanks!

Comment 10 errata-xmlrpc 2023-05-09 07:37:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt-top bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2235