rhc does check the ActiveState of the unit after starting it.

https://github.com/RedHatInsights/rhc/blob/main/activate.go#L31-L34

>	properties, err := conn.GetUnitProperties(unitName)
>	activeState := properties["ActiveState"]
>	if activeState.(string) != "active" {
>		return fmt.Errorf("error: The unit %v failed to start. Run 'systemctl status %v' for more information", unitName, unitName)
>	}

Can you attach the output of `journalctl -u rhcd`? I'm wondering if the unit is starting successfully, is active for the moment that GetUnitProperties is called, and then exits afterwards.

Hey Link,

Sure, here are two examples of failures, one where the failure comes 30 seconds after a start due to network issues and another is a config issue that causes the service to go into failed almost immediately:
~~~
From `journalctl -xfeu rhcd`
Oct 21 15:57:29 rhel9new systemd[1]: Started Red Hat connector daemon.
░░ Subject: A start job for unit rhcd.service has finished successfully
░░ Defined-By: systemd
░░ Support: https://access.redhat.com/support
░░ 
░░ A start job for unit rhcd.service has finished successfully.
░░ 
░░ The job identifier is 50490.
Oct 21 15:57:29 rhel9new rhcd[82810]: [rhcd] 2022/10/21 15:57:29 /builddir/build/BUILD/rhc/yggdrasil-0.2.1/cmd/yggd/main.go:160: starting rhcd version 0.2.1
Oct 21 15:57:29 rhel9new rhcd[82810]: [rhcd] 2022/10/21 15:57:29 /builddir/build/BUILD/rhc/yggdrasil-0.2.1/cmd/yggd/main.go:162: attempting to kill any orphaned workers
Oct 21 15:57:29 rhel9new rhcd[82810]: [rhcd] 2022/10/21 15:57:29 /builddir/build/BUILD/rhc/yggdrasil-0.2.1/cmd/yggd/main.go:209: listening on socket: @yggd-dispatcher-tvnKen
Oct 21 15:57:59 rhel9new rhcd[82810]: cannot connect to broker: network Error : dial tcp 10.10.10.10:3128: i/o timeout
Oct 21 15:57:59 rhel9new systemd[1]: rhcd.service: Main process exited, code=exited, status=1/FAILURE
░░ Subject: Unit process exited
░░ Defined-By: systemd
░░ Support: https://access.redhat.com/support
░░ 
░░ An ExecStart= process belonging to unit rhcd.service has exited.
░░ 
░░ The process' exit code is 'exited' and its exit status is 1.
Oct 21 15:57:59 rhel9new systemd[1]: rhcd.service: Failed with result 'exit-code'.
░░ Subject: Unit failed
░░ Defined-By: systemd
░░ Support: https://access.redhat.com/support
░░ 
░░ The unit rhcd.service has entered the 'failed' state with result 'exit-code'.
Oct 21 15:59:16 rhel9new systemd[1]: Started Red Hat connector daemon.
░░ Subject: A start job for unit rhcd.service has finished successfully
░░ Defined-By: systemd
░░ Support: https://access.redhat.com/support
░░ 
░░ A start job for unit rhcd.service has finished successfully.
░░ 
░░ The job identifier is 50846.
Oct 21 15:59:16 rhel9new rhcd[84105]: 2022/10/21 15:59:16 Unable to load TOML file '/etc/rhc/config.toml': inner error:
Oct 21 15:59:16 rhel9new rhcd[84105]: 'Near line 8 (last key parsed 'env'): expected a comma or array terminator ']', but got '\x00' instead'
Oct 21 15:59:16 rhel9new systemd[1]: rhcd.service: Main process exited, code=exited, status=1/FAILURE
░░ Subject: Unit process exited
░░ Defined-By: systemd
░░ Support: https://access.redhat.com/support
░░ 
░░ An ExecStart= process belonging to unit rhcd.service has exited.
░░ 
░░ The process' exit code is 'exited' and its exit status is 1.
Oct 21 15:59:16 rhel9new systemd[1]: rhcd.service: Failed with result 'exit-code'.
░░ Subject: Unit failed
░░ Defined-By: systemd
░░ Support: https://access.redhat.com/support
░░ 
░░ The unit rhcd.service has entered the 'failed' state with result 'exit-code'.
~~~

In testing both of these scenarios by stopping rhcd and letting `rhc connect` start it up, it still retrieves '● Activated the Red Hat connector daemon'

I was able to reproduce this behavior with rhc-0.2.1-9.el9 easily by breaking the syntax of the config file. This causes rhcd to exit.

Steps to Reproduce
==================

1. systemctl disable --now rhcd
2. echo "blah = " >> /etc/rhc/config.toml
3. rhc connect

Expected Results
================

Output should correctly report whether the service started successfully or not.

Actual Results
==============

Output reports the service was successfully activated. If the service subsequently aborts, that exit status is not reported.

Notes
=====

Technically, this is not a bug. rhc is correct when it reports that the 'rhcd' unit was activated. It doesn't check that the service is still running, or that it successfully started up. It just reports "yep, I told systemd to start the unit, and systemd told me it started". However, I agree that it's a flaw in the UX of the 'rhc connect' operation. Users rightly assume that a message to the effect of "Started a systemd service" with a green checkbox next to it should mean that the service is actively running. To fix this, we'll probably need to block the main routine of rhc until a signal is received from systemd indicating that the service is fully up and running. In order to do *that*, we'll need to enhance rhcd to use the systemd notify protocol to accurately report the service's status as "up and running". This has already been filed as a feature enhancement upstream[1].

1: https://github.com/RedHatInsights/yggdrasil/issues/56

Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues.

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days