Spec URL: https://rominf.fedorapeople.org/python-azure-mgmt-quota.spec SRPM URL: https://rominf.fedorapeople.org/python-azure-mgmt-quota-1.0.0b2-1.fc38.src.rpm Description: Microsoft Azure Quota Management Client Library for Python Fedora Account System Username: rominf
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Version for a 1.0.0 pre-release should be: 1.0.0-0.b2 so that 1.0.0-1 fill follow that (unlike 1.0.0b2, which would be "newer" that 1.0.0) Note the spec file published and the srpm do not use the same spec file! One has a bunch of autorelease stuff at the top? Probably don't want/need that. With the above two issues fixed, the package can be approved. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* MIT License", "MIT License". 12 files have unknown license. Detailed output of licensecheck in /tmp/2136501-python-azure-mgmt-quota/licensecheck.txt [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.11/site- packages/azure(python3-azure-mgmt-deploymentmanager, python3-azure- mgmt-msi, python3-azure-mgmt-web, python3-azure-mgmt-managementgroups, python3-azure-mgmt-core, python3-azure-mgmt-redis, python3-azure-mgmt- kusto, python3-azure-mgmt-imagebuilder, python3-azure-mgmt- policyinsights, python3-azure-mgmt-loganalytics, python3-azure-mgmt- billing, python3-azure-keyvault-administration, python3-azure-mgmt- compute, python3-azure-mgmt-redhatopenshift, python3-azure-mgmt- automanage, python3-azure-mgmt-databoxedge, python3-azure-mgmt-batch, python3-azure-mgmt-network, python3-azure-mgmt-servicelinker, python3-azure-identity, python3-azure-common, python3-azure-mgmt- trafficmanager, python3-azure-mgmt-iotcentral, python3-azure-mgmt- iothub, python3-azure-data-tables, python3-azure-ai-formrecognizer, python3-azure-mgmt-hybridcompute, python3-azure-synapse- managedprivateendpoints, python3-azure-mgmt-eventhub, python3-azure- mgmt-netapp, python3-azure-keyvault-keys, python3-azure-mgmt- apimanagement, python3-azure-mgmt-cosmosdb, python3-azure-mgmt-cdn, python3-azure-mgmt-subscription, python3-azure-mgmt-rdbms, python3-azure-batch, python3-azure-mgmt-authorization, python3-azure- mgmt-hdinsight, python3-azure-mgmt-advisor, python3-azure-servicebus, python3-azure-mgmt-search, python3-azure-mgmt-containerinstance, python3-azure-storage-common, python3-azure-mgmt-media, python3-azure- storage-blob, python3-azure-mgmt-containerservice, python3-azure-mgmt- resource, python3-azure-synapse-artifacts, python3-azure-eventhub, python3-azure-mgmt-cognitiveservices, python3-azure-mgmt-sql, python3-azure-mgmt-eventgrid, python3-azure-mgmt-keyvault, python3-azure-appconfiguration, python3-azure-mgmt- marketplaceordering, python3-azure-mgmt-servicefabricmanagedclusters, python3-azure-mgmt-batchai, python3-azure-mgmt-recoveryservicesbackup, python3-azure-mgmt-containerregistry, python3-azure-mgmt-privatedns, azure-cli, python3-azure-mgmt-servicebus, python3-azure-mgmt-monitor, python3-azure-mgmt-devtestlabs, python3-azure-mgmt-synapse, python3-azure-cosmos, python3-azure-mgmt-servicefabric, python3-azure- mgmt-recoveryservices, python3-azure-mgmt-sqlvirtualmachine, python3-azure-ai-textanalytics, python3-azure-mgmt- applicationinsights, python3-azure-synapse-accesscontrol, python3-azure-multiapi-storage, python3-azure-mgmt-security, python3-azure-graphrbac, python3-azure-mgmt- iothubprovisioningservices, python3-azure-mgmt-azurestackhci, python3-azure-mgmt-extendedlocation, python3-azure-mgmt-dns, python3-azure-mgmt-managedservices, python3-azure-mgmt-dashboard, python3-azure-mgmt-botservice, python3-azure-mgmt-datamigration, python3-azure-mgmt-fluidrelay, python3-azure-synapse-spark, python3-azure-mgmt-maps, python3-azure-mgmt-appconfiguration, python3-azure-keyvault-certificates, python3-azure-mgmt-storage, python3-azure-core, python3-azure-mgmt-signalr, python3-azure- keyvault-secrets, python3-azure-mgmt-reservations, python3-azure- datalake-store), /usr/lib/python3.11/site- packages/azure/mgmt(python3-azure-mgmt-deploymentmanager, python3-azure-mgmt-msi, python3-azure-mgmt-sqlvirtualmachine, python3-azure-mgmt-applicationinsights, python3-azure-mgmt- servicelinker, python3-azure-mgmt-web, python3-azure-mgmt- managementgroups, python3-azure-mgmt-media, python3-azure-mgmt- containerservice, python3-azure-mgmt-resource, python3-azure-mgmt- core, python3-azure-mgmt-security, python3-azure-mgmt-trafficmanager, python3-azure-mgmt-iothub, python3-azure-mgmt-iotcentral, python3-azure-mgmt-iothubprovisioningservices, python3-azure-mgmt- redis, python3-azure-mgmt-hybridcompute, python3-azure-mgmt-eventhub, python3-azure-mgmt-azurestackhci, python3-azure-mgmt-netapp, python3-azure-mgmt-extendedlocation, python3-azure-mgmt- cognitiveservices, python3-azure-mgmt-kusto, python3-azure-mgmt-dns, python3-azure-mgmt-apimanagement, python3-azure-mgmt-dashboard, python3-azure-mgmt-managedservices, python3-azure-mgmt-imagebuilder, python3-azure-mgmt-sql, python3-azure-mgmt-cosmosdb, python3-azure- mgmt-eventgrid, python3-azure-mgmt-keyvault, python3-azure-mgmt- botservice, python3-azure-mgmt-cdn, python3-azure-mgmt-loganalytics, python3-azure-mgmt-marketplaceordering, python3-azure-mgmt-batchai, python3-azure-mgmt-policyinsights, python3-azure-mgmt-datamigration, python3-azure-mgmt-rdbms, python3-azure-mgmt- servicefabricmanagedclusters, python3-azure-mgmt-subscription, python3-azure-mgmt-billing, python3-azure-mgmt-recoveryservicesbackup, python3-azure-mgmt-authorization, python3-azure-mgmt-fluidrelay, python3-azure-mgmt-containerregistry, python3-azure-mgmt-hdinsight, python3-azure-mgmt-compute, python3-azure-mgmt-advisor, python3-azure- mgmt-privatedns, python3-azure-mgmt-maps, python3-azure-mgmt- appconfiguration, python3-azure-mgmt-redhatopenshift, python3-azure- mgmt-containerinstance, python3-azure-mgmt-automanage, python3-azure- mgmt-search, python3-azure-mgmt-databoxedge, python3-azure-mgmt- servicebus, python3-azure-mgmt-monitor, python3-azure-mgmt-storage, python3-azure-mgmt-devtestlabs, python3-azure-mgmt-signalr, python3-azure-mgmt-batch, python3-azure-mgmt-network, python3-azure- mgmt-synapse, python3-azure-mgmt-reservations, python3-azure-mgmt- servicefabric, python3-azure-mgmt-recoveryservices) Odd: but expected :/ [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Not Required. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 python3-azure-mgmt-quota.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/azure/mgmt/quota/operations/__init__.py /usr/lib/python3.11/site-packages/azure/mgmt/quota/aio/operations/__init__.py 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/azure-mgmt-quota/azure-mgmt-quota-1.0.0b2.zip : CHECKSUM(SHA256) this package : 2734f5a9e80bf7ab55dcf04e8b75b5a5f84e677099a117571915f9aa53912e89 CHECKSUM(SHA256) upstream package : 2734f5a9e80bf7ab55dcf04e8b75b5a5f84e677099a117571915f9aa53912e89 Requires -------- python3-azure-mgmt-quota (rpmlib, GLIBC filtered): (python3.11dist(azure-common) >= 1.1 with python3.11dist(azure-common) < 2) (python3.11dist(azure-mgmt-core) < 2~~ with python3.11dist(azure-mgmt-core) >= 1.2) python(abi) python3.11dist(msrest) Provides -------- python3-azure-mgmt-quota: python-azure-mgmt-quota python3-azure-mgmt-quota python3.11-azure-mgmt-quota python3.11dist(azure-mgmt-quota) python3dist(azure-mgmt-quota) Diff spec file in url and in SRPM --------------------------------- --- /tmp/2136501-python-azure-mgmt-quota/srpm/python-azure-mgmt-quota.spec 2022-10-24 11:58:21.866213359 -0400 +++ /tmp/2136501-python-azure-mgmt-quota/srpm-unpacked/python-azure-mgmt-quota.spec 2022-10-20 08:58:20.000000000 -0400 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.3.0) +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global srcname azure-mgmt-quota @@ -48,3 +57,4 @@ %changelog -%autochangelog +* Thu Oct 20 2022 Roman Inflianskas <rominf> 1.0.0b2-1 +- Initial commit Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2136501 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, Ocaml, R, Java, Perl, C/C++, SugarActivity, PHP, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH 304,1 Bot
Thanks, I did a mistake indeed. Fixed the version according https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_complex_versioning_with_a_pre_and_post_release_snapshots Proof: ``` $ rpmdev-vercmp 1.0.0-1 1.0.0~b2-1 1.0.0-1 > 1.0.0~b2-1 ``` SRPM URL: https://rominf.fedorapeople.org/python-azure-mgmt-quota-1.0.0~b2-1.src.rpm Also removed %autochangelog :-)
a little risky depending on the sorting of multiple pre-releases to work as expected :) APPROVED
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-azure-mgmt-quota
FEDORA-2022-d47da23c06 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-d47da23c06
FEDORA-2022-67ef9fc120 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-67ef9fc120
FEDORA-2022-a1c11b2033 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a1c11b2033
FEDORA-2022-d47da23c06 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-d47da23c06 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-d47da23c06 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-67ef9fc120 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-67ef9fc120 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-67ef9fc120 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-a1c11b2033 has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-a1c11b2033 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-a1c11b2033 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-67ef9fc120 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-a1c11b2033 has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-d47da23c06 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.