Bug 2136582 - HOTP counter not updated properly after upgrade to bash-5.2.2-2.fc36.x86_64
Summary: HOTP counter not updated properly after upgrade to bash-5.2.2-2.fc36.x86_64
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pass-otp
Version: 36
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Juan Orti
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-20 16:59 UTC by Chris Mulder
Modified: 2022-11-14 01:13 UTC (History)
1 user (show)

Fixed In Version: pass-otp-1.2.0-10.fc38 pass-otp-1.2.0-10.fc36
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-05 07:09:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github tadfisher pass-otp issues 171 0 None open HOTP uri will be misformated since bash 5.2.2 on Fedora 2022-11-05 06:07:47 UTC

Description Chris Mulder 2022-10-20 16:59:15 UTC
Description of problem:
After upgrading to bash-5.2.2-2.fc36.x86_64 pass otp stops working. 
Error returned is: Invalid key URI (missing counter): otpauth://hotp/OATHXXXXXXXXX?secret=XXXXXXXX&counter=908counter=909&digits=6&issuer=XXXXX

The script in /usr/lib/password-store/extensions/otp.bash no longer correctly updates the counter segment in the URI. 

Version-Release number of selected component (if applicable):
pass-otp-1.2.0-8.fc36.noarch
bash-5.2.2-2.fc36.x86_64

How reproducible:
Execute `pass otp <hotp-pass-name>` 

Steps to Reproduce:
1. Create a new OTP using pass-otp using an HOTP URI
2. Execute `pass otp <hotp-pass-name>` - should receive an OTP
3. Execute `pass otp <hotp-pass-name>` a second time - fails

Actual results:
Invalid key URI (missing counter): otpauth://hotp/OATHXXXXXXXXX?secret=XXXXXXXX&counter=908counter=909&digits=6&issuer=XXXXX

Expected results:
Generated otp

Additional info:
Downgrading to bash-5.1.16-2.fc36.x86_64 resolves the issue.

Comment 1 Fedora Update System 2022-11-05 07:07:04 UTC
FEDORA-2022-54eaf3199a has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-54eaf3199a

Comment 2 Fedora Update System 2022-11-05 07:09:22 UTC
FEDORA-2022-54eaf3199a has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 3 Fedora Update System 2022-11-05 07:12:36 UTC
FEDORA-2022-cdd3fdfb83 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-cdd3fdfb83

Comment 4 Fedora Update System 2022-11-05 07:13:12 UTC
FEDORA-2022-73c05f0d04 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-73c05f0d04

Comment 5 Fedora Update System 2022-11-05 17:06:14 UTC
FEDORA-2022-73c05f0d04 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-73c05f0d04`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-73c05f0d04

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2022-11-06 17:55:03 UTC
FEDORA-2022-cdd3fdfb83 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-cdd3fdfb83`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-cdd3fdfb83

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-11-13 01:17:49 UTC
FEDORA-2022-73c05f0d04 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2022-11-14 01:13:15 UTC
FEDORA-2022-cdd3fdfb83 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.