Bug 2137127 - asv: FTBFS in Fedora Rawhide
Summary: asv: FTBFS in Fedora Rawhide
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: asv
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Elliott Sales de Andrade
QA Contact: Fedora Extras Quality Assurance
URL: https://koschei.fedoraproject.org/pac...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-23 16:55 UTC by Ben Beasley
Modified: 2022-12-19 06:22 UTC (History)
2 users (show)

Fixed In Version: asv-0.5.1-7.fc38
Clone Of:
Environment:
Last Closed: 2022-12-19 06:22:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ben Beasley 2022-10-23 16:55:52 UTC
Description of problem:
Package asv fails to build from source in Fedora Rawhide.

Version-Release number of selected component (if applicable):
0.5.1-5.fc37

Steps to Reproduce:
koji build --scratch f38 asv-0.5.1-5.fc37.src.rpm

Additional info:
This package is tracked by Koschei. See:
https://koschei.fedoraproject.org/package/asv

=================================== FAILURES ===================================
______________________________ test_git_submodule ______________________________
tmpdir = '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0'
    def test_git_submodule(tmpdir):
        tmpdir = six.text_type(tmpdir)
    
        # State 0 (no submodule)
        dvcs = tools.generate_test_repo(tmpdir, values=[0], dvcs_type='git')
        sub_dvcs = tools.generate_test_repo(tmpdir, values=[0], dvcs_type='git')
        ssub_dvcs = tools.generate_test_repo(tmpdir, values=[0], dvcs_type='git')
        commit_hash_0 = dvcs.get_hash("master")
    
        # State 1 (one submodule)
>       dvcs.run_git(['submodule', 'add', sub_dvcs.path, 'sub1'])
/builddir/build/BUILD/asv-0.5.1/test/test_repo.py:330: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test.tools.Git object at 0x7f32ac639a50>
args = ['submodule', 'add', '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repo6w2ko2ul', 'sub1']
chdir = True
kwargs = {'cwd': '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repow28ts9mv'}
cwd = '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repow28ts9mv'
    def run_git(self, args, chdir=True, **kwargs):
        if chdir:
            cwd = self.path
        else:
            cwd = None
        kwargs['cwd'] = cwd
>       return util.check_output(
            [self._git] + args, **kwargs)
E       asv.util.ProcessError: Command '/usr/bin/git submodule add /tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repo6w2ko2ul sub1' returned non-zero exit status 128
/builddir/build/BUILD/asv-0.5.1/test/tools.py:187: ProcessError
----------------------------- Captured stdout call -----------------------------
[100.00%] ·· Error running /usr/bin/git submodule add /tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repo6w2ko2ul sub1 (exit status 128)
             STDOUT -------->
             
             STDERR -------->
             Cloning into '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repow28ts9mv/sub1'...
             fatal: transport 'file' not allowed
             fatal: clone of '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repo6w2ko2ul' into submodule path '/tmp/pytest-of-mockbuild/pytest-0/test_git_submodule0/test_repow28ts9mv/sub1' failed

A little research suggests this is due to fixes in git for CVE-2022-39253

https://github.blog/2022-10-18-git-security-vulnerabilities-announced/#cve-2022-39253

Configuring git with protocol.file.allow=always in the test environment is probably a reasonable workaround.

Comment 1 Ben Beasley 2022-10-24 13:20:58 UTC
(In reply to Ben Beasley from comment #0)
> Configuring git with protocol.file.allow=always in the test environment is
> probably a reasonable workaround.

I opened a PR with this approach: https://src.fedoraproject.org/rpms/asv/pull-request/2

Comment 2 Elliott Sales de Andrade 2022-11-01 03:15:45 UTC
I merged the PR, but I think there's no rush, so will leave it to the next build. Not sure if this is the right status for that.

Comment 3 Fedora Update System 2022-12-19 06:19:46 UTC
FEDORA-2022-44c71c35eb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-44c71c35eb

Comment 4 Fedora Update System 2022-12-19 06:22:04 UTC
FEDORA-2022-44c71c35eb has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.