Spec URL: http://people.atrpms.net/~hdegoede/alex4.spec SRPM URL: http://people.atrpms.net/~hdegoede/alex4-1.0-1.src.rpm Description: In the latest installment of the series Alex travels through the jungle in search of his kidnapped girlfriend. Plenty of classic platforming in four nice colors guaranteed! --- Hmm I just realised this needs work to work properly on PPC (I had to fix some file loading issues on x86_64, but there are endian issues in there too I realise now). I'll report back here with an updated version for PPC soon.
Two quickies. 1. why no _smp_mflags on the make? If it's down to a race condition, can you comment it please 2. --add-category X-Fedora is causing problems for me big style on rawhide. if you enclose it with a conditional that the branch of fedora is < "7", then I'm happy rpmlint is quiet, so that's good :)
rpmlint is quiet builds fine in mock Review - note, that you'll need something for #1 before it's approved (though you can ignore my first comment - I've just seen the smp_mflags!) Good spec file clear and in US English upstream md5 and package md5 are the same license good consistent use of macros permissions fine update-icon-cache fine files permissions good package includes documentation no-devel package required package installs and runs fine (x86 and x86_64) - minimal test though needs work --add-category X-Fedora annoys the buildsys for rawhide Fix the needs work and it's good to go.
Thanks for the review! (In reply to comment #2) > needs work > --add-category X-Fedora annoys the buildsys for rawhide > That is no longer a problem as there has been a new desktop-file-utils system in rawhide for a few days now which fixes this. > Fix the needs work and it's good to go. Well what did really need fixing where the endian issues I already reported, here is a new version with those fixed (no other changes were made): Spec URL: http://people.atrpms.net/~hdegoede/alex4.spec SRPM URL: http://people.atrpms.net/~hdegoede/alex4-1.0-2.src.rpm
It looks good at this end. APPROVED
Thanks! Imported and build, closing.