When the user clicks a template card on the Catalog page, a modal appears with two buttons, "Quick create VirtualMachine" and "Customize VirtualMachine". When the user clicks "Customize VirtualMachine", a "Customize template parameters" modal appears with 3 storage fields and 3 optional parameters. The button on the Customize VirtualMachine is labeled "Review and create VirtualMachine". This suggests that the customization changes made on this modal are displayed and the user can click "Create VirtualMachine" to create the VM. However, the "Review and create VirtualMachine" modal shows a much more comprehensive list of options that the user can configure (Network, Scripts, Disk, YAML, etc.), so it is not actually for reviewing changes. Rather, it is for more configuration options. When I tried changing the storage class of a VM, it was not obvious to me that I had to click "Review and create VirtualMachine" to find that setting. Also, having two "customization" screens (Customize -> "Review"/more customize -> Save) does not follow the normal workflow (Customize -> Save). I recommend removing the "Customize" modal since the same configuration options are available on the "Review and create VirtualMachine" modal. The "Review and create VirtualMachine" modal would be the new "Customize" modal. If certain options on the "Customize VirtualMachine" modal need to be prominent, like the "Mount Windows drivers disk" check box, those options can be added to the Overview tab as well as the relevant component tab.
@apinnick there is a technical reason for the separation of the two: All template parameters (mandatory and optional) must be filled before we can create the VM yaml that can be customized in the next step. Once the VM yaml is created, you cannot modify the template parameters. We may need to modify the name of the template parameters page
(In reply to Ronen from comment #4) > @apinnick there is a technical reason for the separation of the > two: All template parameters (mandatory and optional) must be filled before > we can create the VM yaml that can be customized in the next step. Once the > VM yaml is created, you cannot modify the template parameters. > We may need to modify the name of the template parameters page If the screens need to be separate, perhaps you could rename the first "edit" modal, "Edit template parameters", and change the button label to "Edit VirtualMachine". The second modal could be renamed "Edit VirtualMachine". I think that would make the process clearer.
After discussion with Ronen Sde-Or and Yifat Menchik, we agreed that the simplest solution is to change the label of the "Review and create VirtualMachine" button on the Edit Template Parameters modal to "Next". This change will tell the user that there are more customization settings.
The VM can be created without clicking "Review and create VirtualMachine"/"Next" button, can we add a "Create" button on this page and change "Review and create VirtualMachine"/"Next" button to "More setting"/"More customization" button?
Discussing this again at the scrub meeting, we agreed to change the label of the "Review and create VirtualMachine" button on the Edit Template Parameters modal to "Next".
Fixing: https://github.com/kubevirt-ui/kubevirt-plugin/pull/954
Verified on v4.12.0-158
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Important: OpenShift Virtualization 4.12.0 Images security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2023:0408