Bug 2138152 - Review Request: rust-prettyplease - Minimal `syn` syntax tree pretty-printer
Summary: Review Request: rust-prettyplease - Minimal `syn` syntax tree pretty-printer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-27 12:17 UTC by Jan Macku
Modified: 2022-11-01 09:14 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-11-01 09:14:25 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fabio Valentini 2022-10-27 20:37:53 UTC
Taking this review, will probably get to it tomorrow.

Comment 2 Fabio Valentini 2022-10-31 12:46:47 UTC
Sorry for the delay, package looks good to me.
Minor nit-pick: Please remove the Markdown markup from the package's Summary and this bug's title (i.e. the `code fences`).

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 3 Gwyn Ciesla 2022-10-31 14:08:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-prettyplease

Comment 4 Jan Macku 2022-11-01 08:13:45 UTC
Thank you Fabio, I have removed Markdown markup from the Summary and submitted builds.


Note You need to log in before you can comment on or make changes to this bug.