Bug 2138425 - Review Request: rust-tokio-uring - Io-uring support for the Tokio asynchronous runtime
Summary: Review Request: rust-tokio-uring - Io-uring support for the Tokio asynchronou...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-10-28 18:25 UTC by Fabio Valentini
Modified: 2022-11-19 00:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-19 00:45:41 UTC
Type: ---
Embargoed:
klember: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2022-10-28 18:25:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-tokio-uring.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-tokio-uring-0.3.0-1.fc37.src.rpm

Description:
Io-uring support for the Tokio asynchronous runtime

Fedora Account System Username: decathorpe

koji scratch build for rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=93532545

Comment 1 Kalev Lember 2022-11-16 19:40:04 UTC
Fedora review rust-tokio-uring-0.3.0-1.fc37.src.rpm 2022-11-16

$ rpmlint rust-tokio-uring-0.3.0-1.fc37.src.rpm \
          rust-tokio-uring+default-devel-0.3.0-1.fc38.noarch.rpm \
          rust-tokio-uring+bytes-devel-0.3.0-1.fc38.noarch.rpm \
          rust-tokio-uring-devel-0.3.0-1.fc38.noarch.rpm
=================================================================================== rpmlint session starts ===================================================================================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

rust-tokio-uring-devel.noarch: E: zero-length /usr/share/cargo/registry/tokio-uring-0.3.0/src/driver/bind.rs
rust-tokio-uring+bytes-devel.noarch: W: no-documentation
rust-tokio-uring+default-devel.noarch: W: no-documentation
==================================================== 4 packages and 0 specfiles checked; 1 errors, 2 warnings, 1 badness; has taken 0.1 s ====================================================


+ OK
! needs attention

+ rpmlint output looks good
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
  Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (MIT) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
  SHA512 (tokio-uring-0.3.0.crate) = 9c5262459be86c950b306ce7c999acfa42d6dcdd1de61ad7399d87a34106e9e7bc77b316d1071da0fc67763057acbef5acd735202e6472e39f7c210dc14afc99
  SHA512 (Download/tokio-uring-0.3.0.crate) = 9c5262459be86c950b306ce7c999acfa42d6dcdd1de61ad7399d87a34106e9e7bc77b316d1071da0fc67763057acbef5acd735202e6472e39f7c210dc14afc99
+ Package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files (LICENSE, CHANGELOG.md, README.md are listed twice but that's expected with the rust2rpm generator)
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
+ Package does not depend on deprecated packages

Everything looks nice and clean to me. One thing that I noticed is that upstream just released 0.4.0 if you want to update it to the latest version.

APPROVED

Comment 2 Fabio Valentini 2022-11-18 15:29:36 UTC
Thanks for the review! I'll stick with v0.3 for now, as that's what the Actix needs right now, and update to 0.4 once things have migrated.

https://pagure.io/releng/fedora-scm-requests/issue/49204
https://pagure.io/releng/fedora-scm-requests/issue/49205
https://pagure.io/releng/fedora-scm-requests/issue/49206

Comment 3 Gwyn Ciesla 2022-11-18 15:47:00 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tokio-uring

Comment 4 Fabio Valentini 2022-11-18 23:46:42 UTC
So ... turns out, between submission of the successful scratch build and now, kernel updates in rawhide + f37 broke builds of this package.
I'll need to figure out what happened ...

Comment 5 Fabio Valentini 2022-11-19 00:45:41 UTC
Meh, turns out, tests cannot be run in parallel, and the fact that they passed in the scratch build was a lucky accident.
Fixed by running tests single-threaded, matching the settings upstream uses for running tests in their CI.

https://bodhi.fedoraproject.org/updates/FEDORA-2022-4631ba766a
https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ac8f18b27
https://bodhi.fedoraproject.org/updates/FEDORA-2022-ab879e85f8


Note You need to log in before you can comment on or make changes to this bug.