Note: This bug is displayed in read-only format because
the product is no longer active in Red Hat Bugzilla.
Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
DescriptionBrendan Shephard
2022-10-31 05:24:21 UTC
Description of problem:
When using bearer tokens with Satellite. The token contains an expires_at field. The expires_at field is not part of the RFC for OAuth. Rather it should be expires_in.
Version-Release number of selected component (if applicable):
6.11.0
How reproducible:
Easily
Steps to Reproduce:
1. Request a OAuth token ( We authenticate and return the token like this:
https://github.com/openstack/tripleo-common/blob/master/tripleo_common/image/image_uploader.py#L326)
2. Check contents of token:
{'token': '$2a$09$1b6453892473a467d0737uJ56J02CLEXEkOaX0pdLWgLMlg.qWDSi',
'expires_at': '2022-10-28T04:54:58.296Z',
'issued_at': '2022-10-17T23:45:09.306Z'}
3. Observe expires_at field that is not valid per the RFC for OAuth:
https://www.rfc-editor.org/rfc/rfc6749#section-4.2.2
Actual results:
'expires_at': '2022-10-28T04:54:58.296Z'
Expected results:
The response should adhere to the RFC and contain a `expires_in` field. This field indicates the number of seconds since the issued_at time.
Additional info:
Upstream issue raised as well:
https://projects.theforeman.org/issues/35690
This is impacting us with new versions of Satellite here:
https://bugzilla.redhat.com/show_bug.cgi?id=2134075
Just to be extra sure, would it be ok if we included "expires_in" field in addition to the non-standard field we already have there or is the ask to replace one with the other?
(In reply to Adam Ruzicka from comment #1)
> Just to be extra sure, would it be ok if we included "expires_in" field in
> addition to the non-standard field we already have there or is the ask to
> replace one with the other?
I mean, adding the field would solve the issue I had while integrating with Satellite. So that would be fine from my perspective. Whether or not you should implement the RFC without the expires_at field is probably a seperate question. I'm not sure if there would be any security related concerns with keeping expires_at, it seems as though it was initially included in one of the early OAuth proposals, but then removed when the OAuth v2 RFC was published, maybe there was a reason for that removal that requires further exploration?
Short answer is, "Yes, my query on this BZ is really about having Satellite return the expected expires_in field. Including it in addition to would solve my problem."