Spec URL: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/fedora-rawhide-x86_64/04998876-rubygem-memoizer/rubygem-memoizer.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/fedora-rawhide-x86_64/04998876-rubygem-memoizer/rubygem-memoizer-1.0.3-1.fc38.src.rpm Description: Memoizer caches the results of your method calls, works well with methods that accept arguments or return nil. It's a simpler and more expicit alternative to ActiveSupport::Memoizable Fedora Account System Username: fed500 Comments: a) Dependency of https://github.com/wconrad/ftpd which would like to package. b) rdoc directory currently not packaged due to embedded fonts and javascript. Can be added later once there is a consistent policy.
Some notes * Probably unneeded BuildRequires - Please check if "BR: rubygem(rake)" is really needed. - Also we usually try to remove "BR: rubygem(bundler)", as bundler tries to lock the version of other dependency gems, which we don't want as we are using rpm ecosystem. It seems that removing "require 'bundler/setup'" from spec/spec_helper.rb is sufficient. * Documentation - "Rakefile" is something like "Makefile in Ruby" and usually this is not considered as documentation. - Not a blocker, however I would request "README.md" to be packaged into main package, not in -doc, as README.md is expected to be read by everyone using this rpm.
Thanks for the review. Removed the Rakefile. Removed "BR: rubygem(bundler)". Removed "BR: rubygem(rake)". Put the README.md in the main package. spec: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/fedora-rawhide-x86_64/05047828-rubygem-memoizer/rubygem-memoizer.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/rubygem-memoizer/fedora-rawhide-x86_64/05047828-rubygem-memoizer/rubygem-memoizer-1.0.3-2.fc38.src.rpm
Approving. * Name, EVR, Summary clean * SourceURL, actual source okay, packaged source matches upstream * License appropriate * BuildRequires clean * (generated) Requires sane * %prep, %build, %install, %check okay * %files okay * build on koji successful * installation successful * basic functionality okay * rpmlint sane ========================================================= This package (rubygem-memoizer) is APPROVED by mtasaka =========================================================
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-memoizer