Spec URL: https://dcavalca.fedorapeople.org/review/gimgtools/gimgtools.spec SRPM URL: https://dcavalca.fedorapeople.org/review/gimgtools/gimgtools-0.03^20130918git92d0157-1.fc38.src.rpm Description: gimgtools is a set of command-line tools to examine and manipulate Garmin IMG (the map format) files. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=93646186
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "Unknown or generated". 29 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/gimgtools/2139014-gimgtools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 gimgtools.x86_64: W: no-manual-page-for-binary cmdc gimgtools.x86_64: W: no-manual-page-for-binary gimgch gimgtools.x86_64: W: no-manual-page-for-binary gimgextract gimgtools.x86_64: W: no-manual-page-for-binary gimgfixcmd gimgtools.x86_64: W: no-manual-page-for-binary gimginfo gimgtools.x86_64: W: no-manual-page-for-binary gimgunlock gimgtools.x86_64: W: no-manual-page-for-binary gimgxor 3 packages and 0 specfiles checked; 0 errors, 7 warnings, 0 badness; has taken 8.0 s Source checksums ---------------- https://github.com/wuyongzheng/gimgtools/archive/92d015749e105c5fb8eb704ae503a5c7e51af2bd/gimgtools-92d015749e105c5fb8eb704ae503a5c7e51af2bd.tar.gz : CHECKSUM(SHA256) this package : ac0bfb4f6c0f89a21a9436bac93f2d73696ca29121ec0772c307cabd78e47296 CHECKSUM(SHA256) upstream package : ac0bfb4f6c0f89a21a9436bac93f2d73696ca29121ec0772c307cabd78e47296 Requires -------- gimgtools (rpmlib, GLIBC filtered): libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) gimgtools-debuginfo (rpmlib, GLIBC filtered): gimgtools-debugsource (rpmlib, GLIBC filtered): Provides -------- gimgtools: gimgtools gimgtools(x86-64) gimgtools-debuginfo: debuginfo(build-id) gimgtools-debuginfo gimgtools-debuginfo(x86-64) gimgtools-debugsource: gimgtools-debugsource gimgtools-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2139014 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Haskell, Ocaml, fonts, Perl, Python, Ruby, SugarActivity, Java, R, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Some of the source code seems to be taken from other places: https://github.com/wuyongzheng/gimgtools/blob/master/sf_lbl.c Not sure how extensive this is. Might this affect licensing? b) Is it possible to add smoke tests to check basic functionality?
> a) Some of the source code seems to be taken from other places: > https://github.com/wuyongzheng/gimgtools/blob/master/sf_lbl.c > Not sure how extensive this is. Might this affect licensing? Looks like that comes from libgarmin, which is also GPLv2, so I think we're in the clear. I also did a pass with licensechecker and didn't see anything odd there. > b) Is it possible to add smoke tests to check basic functionality? Not really, as exercising this would require having some map data available.
Ok. Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gimgtools
FEDORA-2023-b34edfd3fa has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b34edfd3fa
FEDORA-2023-b34edfd3fa has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-24c83fa713 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-24c83fa713
FEDORA-2023-9fc228a619 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9fc228a619
FEDORA-2023-24c83fa713 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-24c83fa713 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-24c83fa713 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-9fc228a619 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9fc228a619 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9fc228a619 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-24c83fa713 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-9fc228a619 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.