Bug 2139790

Description of problem:
Snapshot image edit does not allow to update metadata due to empty os_hash_algo or os_hash_value

Version-Release number of selected component (if applicable):
RHOSP16.2.3

How reproducible:

1.Create instance, "do not create volume", wait for instance to be ready.
2."create snapshot". Wait for snapshot-image to be created.
3. Editing the image via horizon enforces either manually specifying or removing os_hash_algo and os_hash_value

Actual results:
the update image dialog considers the form as incomplete and greys out the 'Update Image' button

Expected results:
These fields, if needed to be present as default image property, should have some default value like 'none' or any default to avoid forcing end user to update them or remove them


Additional info:

- Same issue was reported by the customer earlier and bug https://bugzilla.redhat.com/show_bug.cgi?id=2014558 was opened and marked as fixed in 16.2.1.

Customer env. is updated to 16.2.3 and they still see this issue.- Verified the above steps in one of the local env. with RHOSP16.2.3 and it's reproducible.


Detailed analysis done by customer:

===============================
According to 
https://bugzilla.redhat.com/show_bug.cgi?id=2014558
the fix for this is implemented by
https://review.opendev.org/c/openstack/horizon/+/812009/
specifically
https://review.opendev.org/c/openstack/horizon/+/812009/3/horizon/static/framework/widgets/metadata/tree/tree.service.js
which looks at the metadata-item in question and sets the "required" flag to "false" if the value is '' - defined but empty.


checking the database reveals the following:


MariaDB [glance]> select name,os_hash_algo,os_hash_value from glance.images where name="test-snap-16.2.3";
+------------------+--------------+---------------+
| name             | os_hash_algo | os_hash_value |
+------------------+--------------+---------------+
| test-snap-16.2.3 | NULL         | NULL          |
+------------------+--------------+---------------+
1 row in set (0.000 sec)
so both os_hash_algo and os_hash_value are actually 'NULL'  and not '' - which is due to


MariaDB [glance]> show create table images\G
*************************** 1. row ***************************
       Table: images
Create Table: CREATE TABLE `images` (
  `id` varchar(36) NOT NULL,
  `name` varchar(255) DEFAULT NULL,
  `size` bigint(20) DEFAULT NULL,
  `status` varchar(30) NOT NULL,
  `created_at` datetime NOT NULL,
  `updated_at` datetime DEFAULT NULL,
  `deleted_at` datetime DEFAULT NULL,
  `deleted` tinyint(1) NOT NULL,
  `disk_format` varchar(20) DEFAULT NULL,
  `container_format` varchar(20) DEFAULT NULL,
  `checksum` varchar(32) DEFAULT NULL,
  `owner` varchar(255) DEFAULT NULL,
  `min_disk` int(11) NOT NULL,
  `min_ram` int(11) NOT NULL,
  `protected` tinyint(1) NOT NULL DEFAULT 0,
  `virtual_size` bigint(20) DEFAULT NULL,
  `visibility` enum('private','public','shared','community') NOT NULL DEFAULT 'shared',
  `os_hidden` tinyint(1) NOT NULL DEFAULT 0,
  `os_hash_algo` varchar(64) DEFAULT NULL,
  `os_hash_value` varchar(128) DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `checksum_image_idx` (`checksum`),
  KEY `ix_images_deleted` (`deleted`),
  KEY `owner_image_idx` (`owner`),
  KEY `created_at_image_idx` (`created_at`),
  KEY `updated_at_image_idx` (`updated_at`),
  KEY `visibility_image_idx` (`visibility`),
  KEY `os_hidden_image_idx` (`os_hidden`),
  KEY `os_hash_value_image_idx` (`os_hash_value`),
  CONSTRAINT `CONSTRAINT_2` CHECK (`deleted` in (0,1)),
  CONSTRAINT `CONSTRAINT_3` CHECK (`protected` in (0,1)),
  CONSTRAINT `CONSTRAINT_4` CHECK (`os_hidden` in (0,1))
) ENGINE=InnoDB DEFAULT CHARSET=utf8
1 row in set (0.000 sec)
those actually being defined as "DEFAULT NULL" .


I have taken one of our non-production-regions and modified that javascript as follows:


[root@lictrl90001 js]# diff c422e1a2b230.js.backup c422e1a2b230.js
577c577
< Property.prototype.setValue=function(value){if(value===null){this.value=this.type!=='array'?null:[];return;}
---
> Property.prototype.setValue=function(value){if(value===null){console.log(this.name, this.value);this.value=this.type!=='array'?null:[];return;}
which hooks into the function that handles values that are null - undefined - and logs all the names and values that are treated there.


The result is that I get lines for both os_hash_algo and os_hash_value as name and null as value - and since that function has an early return after handling the exceptions these are not made optional.


This patch here
https://www.alle-irre.de/~hardy/0001-Fix-metadata-update-dialog.patch
will take care of actually fixing the issue by also setting fields where the current value is null to be optional.


I am reasonably certain that it is safe to set all items where the value is null to not be required, but there is a chance that this is different for arrays - I don't have any of those here, I don't know if any of those are ever created and then default to null.


We require a hotfix for that - and that hotfix needs to include the hotfix for https://access.redhat.com/support/cases/#/case/03262257 / https://access.redhat.com/solutions/6960775 as well since that's all the same rpms.


===============