Bug 2140535 - [RFE] : osd spec : orchestrator could recognise errors on indentation and provide easier inputs to user
Summary: [RFE] : osd spec : orchestrator could recognise errors on indentation and pro...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Ceph Storage
Classification: Red Hat Storage
Component: Cephadm
Version: 5.3
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 7.0
Assignee: Adam King
QA Contact: Aditya Ramteke
Rivka Pollack
URL:
Whiteboard:
Depends On:
Blocks: 2237662
TreeView+ depends on / blocked
 
Reported: 2022-11-07 05:16 UTC by Vasishta
Modified: 2023-12-13 15:19 UTC (History)
6 users (show)

Fixed In Version: ceph-18.2.0-4.el9cp
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-13 15:19:37 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHCEPH-5565 0 None None None 2022-11-07 06:03:17 UTC
Red Hat Product Errata RHBA-2023:7780 0 None None None 2023-12-13 15:19:42 UTC

Description Vasishta 2022-11-07 05:16:48 UTC
Description of problem:
In OSD spec, 
1) Had missed data_devices, orchestrator errored out saying data_devices missing
2) Had mentioned unrecognised key 'all', orchestrator helped by error'ing out saying 
Error EINVAL: Failed to validate OSD spec "osd": Feature `all` is not supported

But when data_devices was added outside without indentation, error message could have been more easier similar to above helps by orchestrator.

Version-Release number of selected component (if applicable):
16.2.10-69.el8cp

How reproducible:
Always (1/1)

Steps to Reproduce:
1. After cluster bootstrap, use below spec and try to add OSDs
service_type: osd
service_id: osd_all
service_name: osd.osd_all
placement:
  host_pattern: '*'
spec:
  osds_per_device: 2
data_devices:
  all: true

Actual results:
[ceph: root@f12-h10-000-1029u /]# ceph orch apply -i spec.yaml --dry-run
Error EINVAL: ServiceSpec: 'dict' object has no attribute 'validate'

Expected results:
ceph orchestrator to help user with easier error message to immediately know the error
something like

>> Error EINVAL: Failed to validate data_devices

Comment 13 errata-xmlrpc 2023-12-13 15:19:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat Ceph Storage 7.0 Bug Fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:7780


Note You need to log in before you can comment on or make changes to this bug.