Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 2140695

Summary: libguestfs: Consider moving libguestfs-make-fixed-appliance to runtime package
Product: Red Hat Enterprise Linux 9 Reporter: Andrea Bolognani <abologna>
Component: libguestfsAssignee: Richard W.M. Jones <rjones>
Status: CLOSED ERRATA QA Contact: YongkuiGuo <yoguo>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 9.1CC: afrosi, lersek, rjones, virt-maint, yoguo
Target Milestone: rcKeywords: Triaged
Target Release: ---Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libguestfs-1.48.4-3.el9 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-05-09 07:36:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andrea Bolognani 2022-11-07 16:41:48 UTC
libguestfs support in KubeVirt currently works by generating a fixed
appliance ahead of time and bundling it into the container image that
contains libguestfs.

The appliance is generated using libguestfs-make-fixed-appliance:

  https://github.com/kubevirt/libguestfs-appliance/blob/9c597f6c6ff49b5317680cda280b350fb92530f2/Dockerfile#L15

and overall everything works pretty much as intended.

In order to have libguestfs-make-fixed-appliance available, however,
we need to install the libguestfs-devel package, which in turn
requires enabling the CRB repository:

  https://github.com/kubevirt/libguestfs-appliance/blob/9c597f6c6ff49b5317680cda280b350fb92530f2/Dockerfile#L7-L10

The fact that libguestfs-make-fixed-appliance is part of the
libguestfs-devel package as opposed to the runtime package was
surprising to me when I found out about it. Usually -devel packages
contain stuff that's needed when developing against a library, and
libguestfs-make-fixed-appliance doesn't seem to fit the bill.

It's not a big deal either way, but please consider whether it would
make sense to move libguestfs-make-fixed-appliance into the runtime
package.

Thanks!

Comment 1 Richard W.M. Jones 2022-11-08 13:21:19 UTC
Ah CRB, the gift that keeps on giving.

Here's the Fedora change:
https://src.fedoraproject.org/rpms/libguestfs/c/ea7571f662909f7d341499f0e4aad36f9aaf7372?branch=rawhide
and scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=93944133

Comment 2 Richard W.M. Jones 2022-11-08 13:22:34 UTC
Yongkui - can you look at the above for QA ACK please?
It's just moving a couple of files between packages and
changing a dependency, so very simple.

Comment 3 YongkuiGuo 2022-11-08 14:08:53 UTC
(In reply to Richard W.M. Jones from comment #2)
> Yongkui - can you look at the above for QA ACK please?
> It's just moving a couple of files between packages and
> changing a dependency, so very simple.

Done.

Comment 4 Andrea Bolognani 2022-11-08 16:55:13 UTC
(In reply to Richard W.M. Jones from comment #1)
> Ah CRB, the gift that keeps on giving.
> 
> Here's the Fedora change:
> https://src.fedoraproject.org/rpms/libguestfs/c/
> ea7571f662909f7d341499f0e4aad36f9aaf7372?branch=rawhide
> and scratch build:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=93944133

Excellent stuff! Thanks for looking into this so quickly :)

Comment 5 YongkuiGuo 2022-11-09 11:45:34 UTC
Test with package:
libguestfs-1.48.4-3.el9.x86_64


Steps:


1. On rhel9.2 host
$ rpm -ql libguestfs | grep libguestfs-make-fixed-appliance
/usr/sbin/libguestfs-make-fixed-appliance
/usr/share/man/man1/libguestfs-make-fixed-appliance.1.gz

2.
$ libguestfs-make-fixed-appliance --xz
$ ll
total 136340
-rw-rw-r--. 1 yoguo yoguo 139609696 Nov  9 06:36 appliance-1.48.4.tar.xz
$ xz -d appliance-1.48.4.tar.xz
$ tar xvf appliance-1.48.4.tar
appliance/
appliance/kernel
appliance/initrd
appliance/root
appliance/README.fixed

It works well.

Comment 8 YongkuiGuo 2023-01-20 02:57:33 UTC
Verified this bug as this bug has been automated and the test case passed in the latest nightly compose test.

Comment 10 errata-xmlrpc 2023-05-09 07:36:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libguestfs bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2231