Bug 2141719

Description of problem:

While selecting the "Enable debugging output" option, Satellite generates ahv virt-who configuration with "internal_debug=true" which is not recognized by virt-who

The correct option is "ahv_internal_debug=true"

Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1986749 

But the virt-who plugin of foreman still uses the old parameter i.e. https://github.com/theforeman/foreman_virt_who_configure/blob/master/app/models/foreman_virt_who_configure/output_generator.rb#L173 


Version-Release number of selected component (if applicable):

Satellite 6.11 and Satellite 6.12

rubygem-foreman_virt_who_configure-0.5.9-1


How reproducible:

Always


Steps to Reproduce:
1. Install a Satellite 6.11 or 6.12
2. Go to Infrastructure --> Virt-who Configurations
3. Select all necessary options to create a Nutanix-specific config and ensure to select both the "Enable debugging output" and "Enable AHV debug" options.
4. Click on the "Deploy" tab, scroll down to the "Configuration script:" section and check the bash script.

Actual results:

--> internal_debug=true is used


  cat > /etc/virt-who.d/virt-who-config-6.conf << EOF
### This configuration file is managed via the virt-who configure plugin
### manual edits will be deleted.
[virt-who-config-6]
type=ahv
hypervisor_id=hostname
owner=RedHat

server=1.2.3.4
username=sayan
encrypted_password=$cr_password
rhsm_hostname=breakfix9-sat.syslab.pnq2.redhat.com
rhsm_username=
rhsm_encrypted_password=$user_password
rhsm_prefix=/rhsm
prism_central=false
internal_debug=true
EOF


And after deploying this config, "virt-who -od" would show this:
~~
2022-10-21 16:52:54,306 [virtwho.rhsm_log DEBUG] MainProcess(43625):MainThread @config.py:init_config:1594 - [virt-who-config-18]: Value for "ahv_internal_debug" not set, using default: False

2022-10-21 16:52:54,307 [virtwho.rhsm_log WARNING] MainProcess(43625):MainThread @config.py:init_config:1594 - [virt-who-config-18]: Ignoring unknown configuration option "internal_debug"

~~



Expected results:

That option should be "ahv_internal_debug=true"




Additional info:

Applying this patch followed by a restart of satellite services , fixes the issue:

# git diff
diff --git a/app/models/foreman_virt_who_configure/output_generator.rb b/app/models/foreman_virt_who_configure/output_generator.rb
index ab0ec00..3fd5ed8 100644
--- a/app/models/foreman_virt_who_configure/output_generator.rb
+++ b/app/models/foreman_virt_who_configure/output_generator.rb
@@ -170,7 +170,7 @@ encrypted_password=$cr_password"
       if config.hypervisor_type == 'ahv'
         prism_central = config.prism_flavor == "central"
         update_interval = config.ahv_update_interval.present? ? "\nupdate_interval=#{config.ahv_update_interval}" : nil
-        internal_debug = config.ahv_internal_debug.present? ? "\ninternal_debug=#{config.ahv_internal_debug}" : nil
+        internal_debug = config.ahv_internal_debug.present? ? "\nahv_internal_debug=#{config.ahv_internal_debug}" : nil
 
         "\nprism_central=#{prism_central}#{internal_debug}#{update_interval}"
       else