Spec URL: https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated.spec SRPM URL: https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated-2.0.1-1.fc38.src.rpm Description: No language, library or framework ever get everything right from the very beginning. The project evolves, new features are added/changed/removed. This means that projects relying on them must keep an eye on what's currently best practices. This flake8 plugin helps you keeping up with method deprecations and giving hints about what they should be replaced with. Fedora Account System Username: cottsay Target branches: f36 f37 epel9 Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94030756 Thanks!
Spec URL: https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated.spec SRPM URL: https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated-2.0.1-2.fc38.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94432384
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
The spec files looks good overall but I have a minor question: * Does it need a %license directive to store its license file?
> Does it need a %license directive to store its license file? Great question. This was actually revealed to me moderately recently, but "modern" Python packages will install their `LICENSE` file as part of the Python metadata if it was properly declared in the package. This is the case for flake8-deprecated: $ rpm -qlp RPMS/noarch/python3-flake8-deprecated-2.0.1-2.fc39.noarch.rpm | grep LICENSE /usr/lib/python3.12/site-packages/flake8_deprecated-2.0.1.dist-info/LICENSE I can't find mention of it directly in the Python Packaging Guidelines[1], but there is mention of a macro flag to cause a build break if the LICENSE file is removed for whatever reason. I've updated the package to include that flag. There have also been releases in the ~18 months it's been since I submitted this review, so I updated the package to the latest release, 2.2.1. Spec URL: https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated.spec SRPM URL: https://cottsay.fedorapeople.org/python-flake8-deprecated/python-flake8-deprecated-2.2.1-1.fc41.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=115262591 [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros
Copr build: https://copr.fedorainfracloud.org/coprs/build/7194404 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2141870-python-flake8-deprecated/fedora-rawhide-x86_64/07194404-python-flake8-deprecated/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.