Bug 2141999 - Add "controller" field to interface to attach to bridge, bond.
Summary: Add "controller" field to interface to attach to bridge, bond.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: nmstate
Version: 8.6
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: ---
Assignee: Gris Ge
QA Contact: Mingyu Shi
URL:
Whiteboard:
Depends On:
Blocks: 2142003
TreeView+ depends on / blocked
 
Reported: 2022-11-11 11:25 UTC by Quique Llorente
Modified: 2023-05-16 09:25 UTC (History)
5 users (show)

Fixed In Version: nmstate-1.4.0-0.alpha.20221201.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2142003 (view as bug list)
Environment:
Last Closed: 2023-05-16 08:26:38 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github nmstate nmstate pull 2103 0 None open [nmstate-1.3] python: iface: Add support of controller property 2022-11-16 11:03:29 UTC
Red Hat Issue Tracker NMT-124 0 None None None 2023-01-22 15:28:47 UTC
Red Hat Issue Tracker RHELPLAN-139158 0 None None None 2022-11-11 11:31:26 UTC
Red Hat Product Errata RHBA-2023:2772 0 None None None 2023-05-16 08:27:16 UTC

Description Quique Llorente 2022-11-11 11:25:04 UTC
Description of problem:

Right now adding a port a bridge means modify the "port" field of the bridge so the previous port has to be also included or they will be removed.

We can add a "controller" field to interfaces to they just  get attached to the bridge, port.

Version-Release number of selected component (if applicable):


How reproducible: Always


Steps to Reproduce:
1. Add a interface as a new bridge port modifying the bridge "port" field with just the interface

Actual results:
The other ports get removed


Expected results:
It should merge it with the ports or we should have a controller field at interfaces.


Additional info:

Comment 1 Gris Ge 2022-11-16 11:02:34 UTC
Patch posted to upstream: https://github.com/nmstate/nmstate/pull/2103

Example on attach eth1 to br0:

```yaml
---
interfaces:
- name: eth1
  state: up
  controller: br0
```

Comment 8 Mingyu Shi 2023-02-03 06:55:36 UTC
Verified with:
nmstate-1.4.1-1.el8.x86_64
nispor-1.2.9-1.el8.x86_64
NetworkManager-1.40.10-1.el8.x86_64
openvswitch2.15-2.15.0-133.el8fdp.x86_64
DISTRO=RHEL-8.8.0-20230127.0

But there's a little difference between nmstate python and rust when *changing* controller. I'm discussing which one is better and if it is worth fixing on RHEL 8.

Comment 10 errata-xmlrpc 2023-05-16 08:26:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (nmstate bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2772


Note You need to log in before you can comment on or make changes to this bug.