Bug 2142037 - python-pdm-pep517 fails to build with pytest 7.2 - missing dependency on python3-setuptools
Summary: python-pdm-pep517 fails to build with pytest 7.2 - missing dependency on pyth...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-pdm-pep517
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Simon de Vlieger
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 2137514
TreeView+ depends on / blocked
 
Reported: 2022-11-11 13:01 UTC by Lumír Balhar
Modified: 2022-11-21 01:13 UTC (History)
1 user (show)

Fixed In Version: python-pdm-pep517-1.0.4-3.fc37 python-pdm-pep517-1.0.4-3.fc36 python-pdm-pep517-1.0.4-3.el9
Clone Of:
Environment:
Last Closed: 2022-11-21 01:07:30 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Lumír Balhar 2022-11-11 13:01:55 UTC
I'm testing an update to pytest 7.2.0 and I've discovered a problem with this package.

This package needs python3-setuptools to build but this dependency is not specified as a BuildRequires in its specfile.

This fact didn't cause any trouble before because python3-pytest <7.2 depends on python3-setuptools so setuptools have been installed as a transitive dependency. pytest uses a different build backend now which means that when we update it to the latest version, this package will fail to build.

The plan is to update pytest in ~2 weeks.

If you want to, you can find the failed build in https://copr.fedorainfracloud.org/coprs/lbalhar/pytest/

Comment 1 Simon de Vlieger 2022-11-11 16:22:18 UTC
I'll add this to BuildRequires in all branches, interesting that the pyproject_buildrequires macro doesn't handle this case :)

Comment 2 Lumír Balhar 2022-11-11 19:40:23 UTC
%pyproject_buildrequires should handle this if the dependency is specified in upstream metadata. I see that upstream code uses setuptools in tests and I also see setuptools in the pdm.lock but I have no idea whether this is an optional dependency just for tests. The problem might be there, not in the specfile. Strange is that setuptools is in pdm.lock but not in pyproject.toml. Do you understand pdm well enough to check it and possibly report an issue there?

Comment 3 Simon de Vlieger 2022-11-11 21:00:34 UTC
Not really no, for now I've added a BuildRequires for python3-setuptools and triggered builds for all branches: https://koji.fedoraproject.org/koji/packageinfo?packageID=36139 so that the immediate concern is gone.

I'll have this ticket be closed by bodhi after I submit updates and might take a deeper look into the rest of it if I get to it.

Comment 4 Fedora Update System 2022-11-11 21:03:27 UTC
FEDORA-2022-b8392d0f6b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b8392d0f6b

Comment 5 Fedora Update System 2022-11-11 21:03:28 UTC
FEDORA-2022-ef631ada81 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-ef631ada81

Comment 6 Fedora Update System 2022-11-11 21:03:30 UTC
FEDORA-EPEL-2022-b6bab7dc81 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-b6bab7dc81

Comment 7 Fedora Update System 2022-11-13 01:28:11 UTC
FEDORA-EPEL-2022-b6bab7dc81 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-b6bab7dc81

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-11-13 02:34:47 UTC
FEDORA-2022-ef631ada81 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-ef631ada81`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-ef631ada81

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-11-13 02:39:15 UTC
FEDORA-2022-b8392d0f6b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-b8392d0f6b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b8392d0f6b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Lumír Balhar 2022-11-14 11:51:01 UTC
I fixed the problem upstream: https://github.com/pdm-project/pdm-pep517/pull/131

Comment 11 Fedora Update System 2022-11-21 01:07:30 UTC
FEDORA-2022-ef631ada81 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-11-21 01:13:31 UTC
FEDORA-2022-b8392d0f6b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-11-21 01:13:46 UTC
FEDORA-EPEL-2022-b6bab7dc81 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.