RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2142608 - rebase to version 1.6
Summary: rebase to version 1.6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: python-virt-firmware
Version: 9.2
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Gerd Hoffmann
QA Contact: Xueqiang Wei
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-11-14 15:07 UTC by Gerd Hoffmann
Modified: 2023-05-09 08:39 UTC (History)
2 users (show)

Fixed In Version: python-virt-firmware-1.6-2.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-09 07:37:28 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-139305 0 None None None 2022-11-14 15:17:27 UTC
Red Hat Product Errata RHEA-2023:2238 0 None None None 2023-05-09 07:37:31 UTC

Description Gerd Hoffmann 2022-11-14 15:07:31 UTC 
- get latest upstream changes
- get tests sub-package
- drop peutils (needs 'python3dist(pefile)' which is not in rhel).
Comment 1 Gerd Hoffmann 2022-11-14 15:46:52 UTC 
https://gitlab.com/redhat/centos-stream/rpms/python-virt-firmware/-/merge_requests/2
Comment 3 Xueqiang Wei 2022-11-15 18:47:50 UTC 
Tested with the following steps:

Versions
edk2-ovmf-20220826gitba0e0e4c6a-1.el9.noarch
python3-virt-firmware-1.6-2.el9.noarch.rpm
python3-virt-firmware-tests-1.6-2.el9.noarch.rpm

1. install python3-virt-firmware-1.6-2.el9.noarch.rpm and python3-virt-firmware-tests-1.6-2.el9.noarch.rpm
2. run tests under /usr/share/python-virt-firmware/tests
  # cd /usr/share/python-virt-firmware/tests
  # ls
  data  test-dump.sh  test-pe.sh  test-sigdb.sh  tests.py  test-vars.sh
  
After step 2:
Run the four scripts test-dump.sh, test-sigdb.sh, tests.py and test-vars.sh, the results were passed.

For test-pe.sh, hit the following error.
# sh test-pe.sh 
+ pe-dumpinfo --help
test-pe.sh: line 7: pe-dumpinfo: command not found


Hi Gerd,

According to Description "drop peutils (needs 'python3dist(pefile)' which is not in rhel).", I think this is the expected result. Am I right?
And if "peutils" was dropped, I think we should remove "test-pe.sh" from python3-virt-firmware-tests-1.6-2.el9 package. What's your opinion?

Many thanks.
Comment 4 Gerd Hoffmann 2022-11-16 07:43:14 UTC 
> According to Description "drop peutils (needs 'python3dist(pefile)' which is
> not in rhel).", I think this is the expected result. Am I right?

Yes.

peutils can inspect efi binaries, it's not really needed for the virt-firmware
core functionality and there is functional overlap with sbsign.rpm so I just
dropped them instead of packaging peutils as dependeny.

> And if "peutils" was dropped, I think we should remove "test-pe.sh" from
> python3-virt-firmware-tests-1.6-2.el9 package. What's your opinion?

Yes, can be dropped.
Comment 5 Xueqiang Wei 2022-11-16 09:49:04 UTC 
(In reply to Gerd Hoffmann from comment #4)
> > According to Description "drop peutils (needs 'python3dist(pefile)' which is
> > not in rhel).", I think this is the expected result. Am I right?
> 
> Yes.
> 
> peutils can inspect efi binaries, it's not really needed for the
> virt-firmware
> core functionality and there is functional overlap with sbsign.rpm so I just
> dropped them instead of packaging peutils as dependeny.
> 
> > And if "peutils" was dropped, I think we should remove "test-pe.sh" from
> > python3-virt-firmware-tests-1.6-2.el9 package. What's your opinion?
> 
> Yes, can be dropped.


Thank you Gerd for your confirmation. If we remove "test-pe.sh" from current version(python3-virt-firmware-tests-1.6-2.el9), do we use this bug to track this requirement, or create a new bug to track it? Or remove "test-pe.sh" in the next version of python3-virt-firmware-tests? Thanks.
Comment 6 Gerd Hoffmann 2022-11-17 08:25:06 UTC 
> Thank you Gerd for your confirmation. If we remove "test-pe.sh" from current
> version(python3-virt-firmware-tests-1.6-2.el9), do we use this bug to track
> this requirement, or create a new bug to track it? Or remove "test-pe.sh" in
> the next version of python3-virt-firmware-tests? Thanks.

My plan is to do it the next time I update the package.
Opening a (low priority) bug as reminder is probably a good idea.
Comment 7 Xueqiang Wei 2022-11-17 08:30:49 UTC 
(In reply to Gerd Hoffmann from comment #6)
> > Thank you Gerd for your confirmation. If we remove "test-pe.sh" from current
> > version(python3-virt-firmware-tests-1.6-2.el9), do we use this bug to track
> > this requirement, or create a new bug to track it? Or remove "test-pe.sh" in
> > the next version of python3-virt-firmware-tests? Thanks.
> 
> My plan is to do it the next time I update the package.
> Opening a (low priority) bug as reminder is probably a good idea.


Thank you Gerd for your confirmation. I will open a low priority bug to track the change. And Set the status of this bug to VERIFIED. Many thanks.
Comment 8 Xueqiang Wei 2022-11-17 09:12:27 UTC 
According to Comment 3, Comment 4 and Comment 7, set status to VERIFIED. Thanks.
Comment 10 errata-xmlrpc 2023-05-09 07:37:28 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (python-virt-firmware bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:2238
Note You need to log in before you can comment on or make changes to this bug.