Bug 2142608
| Summary: | rebase to version 1.6 | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 9 | Reporter: | Gerd Hoffmann <kraxel> |
| Component: | python-virt-firmware | Assignee: | Gerd Hoffmann <kraxel> |
| Status: | CLOSED ERRATA | QA Contact: | Xueqiang Wei <xuwei> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 9.2 | CC: | jinzhao, zhguo |
| Target Milestone: | rc | Keywords: | Triaged |
| Target Release: | --- | Flags: | pm-rhel:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-virt-firmware-1.6-2.el9 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-05-09 07:37:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gerd Hoffmann
2022-11-14 15:07:31 UTC
Tested with the following steps: Versions edk2-ovmf-20220826gitba0e0e4c6a-1.el9.noarch python3-virt-firmware-1.6-2.el9.noarch.rpm python3-virt-firmware-tests-1.6-2.el9.noarch.rpm 1. install python3-virt-firmware-1.6-2.el9.noarch.rpm and python3-virt-firmware-tests-1.6-2.el9.noarch.rpm 2. run tests under /usr/share/python-virt-firmware/tests # cd /usr/share/python-virt-firmware/tests # ls data test-dump.sh test-pe.sh test-sigdb.sh tests.py test-vars.sh After step 2: Run the four scripts test-dump.sh, test-sigdb.sh, tests.py and test-vars.sh, the results were passed. For test-pe.sh, hit the following error. # sh test-pe.sh + pe-dumpinfo --help test-pe.sh: line 7: pe-dumpinfo: command not found Hi Gerd, According to Description "drop peutils (needs 'python3dist(pefile)' which is not in rhel).", I think this is the expected result. Am I right? And if "peutils" was dropped, I think we should remove "test-pe.sh" from python3-virt-firmware-tests-1.6-2.el9 package. What's your opinion? Many thanks. > According to Description "drop peutils (needs 'python3dist(pefile)' which is > not in rhel).", I think this is the expected result. Am I right? Yes. peutils can inspect efi binaries, it's not really needed for the virt-firmware core functionality and there is functional overlap with sbsign.rpm so I just dropped them instead of packaging peutils as dependeny. > And if "peutils" was dropped, I think we should remove "test-pe.sh" from > python3-virt-firmware-tests-1.6-2.el9 package. What's your opinion? Yes, can be dropped. (In reply to Gerd Hoffmann from comment #4) > > According to Description "drop peutils (needs 'python3dist(pefile)' which is > > not in rhel).", I think this is the expected result. Am I right? > > Yes. > > peutils can inspect efi binaries, it's not really needed for the > virt-firmware > core functionality and there is functional overlap with sbsign.rpm so I just > dropped them instead of packaging peutils as dependeny. > > > And if "peutils" was dropped, I think we should remove "test-pe.sh" from > > python3-virt-firmware-tests-1.6-2.el9 package. What's your opinion? > > Yes, can be dropped. Thank you Gerd for your confirmation. If we remove "test-pe.sh" from current version(python3-virt-firmware-tests-1.6-2.el9), do we use this bug to track this requirement, or create a new bug to track it? Or remove "test-pe.sh" in the next version of python3-virt-firmware-tests? Thanks. > Thank you Gerd for your confirmation. If we remove "test-pe.sh" from current
> version(python3-virt-firmware-tests-1.6-2.el9), do we use this bug to track
> this requirement, or create a new bug to track it? Or remove "test-pe.sh" in
> the next version of python3-virt-firmware-tests? Thanks.
My plan is to do it the next time I update the package.
Opening a (low priority) bug as reminder is probably a good idea.
(In reply to Gerd Hoffmann from comment #6) > > Thank you Gerd for your confirmation. If we remove "test-pe.sh" from current > > version(python3-virt-firmware-tests-1.6-2.el9), do we use this bug to track > > this requirement, or create a new bug to track it? Or remove "test-pe.sh" in > > the next version of python3-virt-firmware-tests? Thanks. > > My plan is to do it the next time I update the package. > Opening a (low priority) bug as reminder is probably a good idea. Thank you Gerd for your confirmation. I will open a low priority bug to track the change. And Set the status of this bug to VERIFIED. Many thanks. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (python-virt-firmware bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2023:2238 |