Bug 2143311 - Review Request: rust-libadwaita - Rust bindings for libadwaita
Summary: Review Request: rust-libadwaita - Rust bindings for libadwaita
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2066122 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-11-16 15:25 UTC by Kalev Lember
Modified: 2022-11-18 18:50 UTC (History)
3 users (show)

Fixed In Version: rust-libadwaita-0.1.1-1.fc37 rust-libadwaita-0.1.1-1.fc38
Clone Of:
Environment:
Last Closed: 2022-11-18 18:50:32 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2022-11-16 15:25:14 UTC
Spec URL: https://kalev.fedorapeople.org/rust-libadwaita.spec
SRPM URL: https://kalev.fedorapeople.org/rust-libadwaita-0.1.1-1.fc38.src.rpm
Description: Rust bindings for libadwaita.
Fedora Account System Username: kalev

Note that this is at version 0.1.1 (there's newer 0.2 available) because we don't have new enough rust gtk4 stack in rawhide.

Comment 1 Kalev Lember 2022-11-16 15:28:08 UTC
*** Bug 2066122 has been marked as a duplicate of this bug. ***

Comment 2 Fabio Valentini 2022-11-18 15:42:40 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged (latest possible version, for now)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files (manually included for now)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

It always throws me off when projects use the "French" spelling for LICENCE :)

Comment 3 Gwyn Ciesla 2022-11-18 17:01:10 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libadwaita

Comment 4 Kalev Lember 2022-11-18 18:50:32 UTC
Thanks! Package imported and built.


Note You need to log in before you can comment on or make changes to this bug.