Bug 2143640 - tcl-signal: Adjustments for additional C type checks in GCC 14
Summary: tcl-signal: Adjustments for additional C type checks in GCC 14
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: tcl-signal
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCNoUpstream
TreeView+ depends on / blocked
 
Reported: 2022-11-17 13:29 UTC by Florian Weimer
Modified: 2024-01-05 15:59 UTC (History)
1 user (show)

Fixed In Version: tcl-signal-1.4-29.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-18 07:37:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
tcl-signal-c99-2.patch (2.13 KB, patch)
2024-01-05 15:58 UTC, Florian Weimer
no flags Details | Diff

Description Florian Weimer 2022-11-17 13:29:36 UTC
configure has an old ac_cv_header_stdc fragment that calls an undeclared exit function instead of returning from main.

Last upstream release apparently was in 2003, even though the web page is still up (without an apparent contact address). So this needs to be fixed in a downstream patch.

Comment 1 Florian Weimer 2022-11-18 07:37:26 UTC
Patch looks like this.  This is generic autoconf-generated code, fixed in later versions. Other packages will likely need that as well.

diff --git a/configure b/configure
index 6d93d976873e878e..ed02d3f7fe44d2ab 100755
--- a/configure
+++ b/configure
@@ -747,8 +747,8 @@ else
 #define TOUPPER(c) (ISLOWER(c) ? 'A' + ((c) - 'a') : (c))
 #define XOR(e, f) (((e) && !(f)) || (!(e) && (f)))
 int main () { int i; for (i = 0; i < 256; i++)
-if (XOR (islower (i), ISLOWER (i)) || toupper (i) != TOUPPER (i)) exit(2);
-exit (0); }
+if (XOR (islower (i), ISLOWER (i)) || toupper (i) != TOUPPER (i)) return 2;
+return 0; }
 
 EOF
 if { (eval echo configure:753: \"$ac_link\") 1>&5; (eval $ac_link) 2>&5; } && test -s conftest${ac_exeext} && (./conftest; exit) 2>/dev/null

Comment 2 Florian Weimer 2024-01-05 15:58:33 UTC
Created attachment 2007366 [details]
tcl-signal-c99-2.patch

More fixes are needed for GCC 14 compatibility.


Note You need to log in before you can comment on or make changes to this bug.