RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Description of problem:
When a worker prints a long line of text to stdout, the bufio.Scanner used to read lines of text from the worker's stdout pipe errors. This appears to cause rhcd to stop dispatching further messages correctly.

Version-Release number of selected component (if applicable):
0.2.1

How reproducible:


Steps to Reproduce:
1. Start rhcd, letting it start up rhc-worker-playbook
2. Send a playbook that creates a lot of output

Actual results:
rhcd prints the error message:
2022/11/07 12:47:40 /builddir/build/BUILD/rhc/yggdrasil-0.2.1/cmd/yggd/exec.go:62: cannot read from stdout: bufio.Scanner: token too long

Expected results:
No error should be printed

Additional info:

Originally reported in https://issues.redhat.com/browse/ADVISOR-2872

At the end of a playbook run, rhc-worker-playbook prints to stdout an array of all ansible-runner events collected during the run. For certain playbooks, this array can become quite large, as it contains the stdout of all the tasks executed during the playbook run. In the case of ADVISOR-2872, the final line of output is 315016 characters long. This exceeds the maximum token size when scanning by lines using a bufio.Scanner by a significant amount. The default token size is 64 * 1024 = 65536. Hence the error message.

Rewriting the goroutines that read output from workers avoids hitting this bufio.ErrTooLong error. I've included a patch in PR #100 that reads output from workers using a fixed-length buffer of 4096 bytes. It calls Read directly on the stdout and stderr file handles instead of using a bufio.Scanner to read variable-length lines.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhc bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2819