Hey folks, my first Fedora package, for an application I wrote called OliveTin ( http://olivetin.app or http://github.com/OliveTin/OliveTin ).

The package builds on my machine with mock, and tested it for functionality against an unmodified Fedora 36 libvirt VM, where it seems to work well. rpmlint passes without any issues raised. I've read through the Fedora packaging guidelines as best I can over the last few days, and don't think there are any outstanding issues.

I'd like to raise to your attention, that OliveTin "tracks" versions as part of update checking, and sends an installation ID (random UUID) as part of that checking/tracking. This is on by default (but absolutely can be disabled), and is documented with as much information as possible here; https://docs.olivetin.app/update-tracking.html . It was unclear if the Fedora project would consider this an issue as I didn't find a guideline against it. If it's an issue for Fedora the default config file can be patched to disable that behavior, but I'm hoping it can be left enabled as it really helps me understand how many old versions are out there in the wild (and how long to support them). How the data is used, and how it works is documented in detail at the above link. 

Lastly, the very awesome Fabio Alessandro “Fale” Locati has been kind enough to offer his time to help me build the first package, and I know him well. He's offered to be a sponsor/reviewer.

Successful Koji scratch buuld: https://koji.fedoraproject.org/koji/taskinfo?taskID=94288784

Hi James,

Glad to see that you managed to package OliveTin.

There are a couple of things to cleanup on the spec file, to start with:

1. Please rename the package to OliveTin (and also this Review Request) so that it's aligned with the upstream project name as for the known packages exception in go's Fedora policy
2. Drop the %patch since it is not used
3. Replace the `cp` and `chown` commands in the install section with `install`
4. Use the https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/ policy for the systemd unit

Best,
Fale

Hey Fale, 

Many thanks indeed for your time looking into this today, it's really appreciated.

1. spec file and package renamed to OliveTin. That's originally what I wanted as well actually, so that's great. 
2. Patch dropped - sorry, that was sloppy of me. I forgot to remove that line.
3. cp/chown -> install - I must have been doing something silly, but I tried for quite a long time to get the install command to work. Out of frustration I just used cp/chown in the end. Thanks for the help in fixing this, I would not have anticipated I needed to find/loop over files to install them.
4. systemd triggers: Ah, I thought they had been automatically added by existing RPM macros, but thank you for that.

On the few suggestions you send me offline, the two I rejected where; 

- Changes to summary to add "OliveTin" -  as this triggers a rpmlint warning. 
- %_sysconfigdir needed to be %_sysconfdir

Commit c1ed6d6 should make this ready for review again; https://github.com/OliveTin/OliveTin-package-fedora/blob/main/OliveTin.spec

Great work!

go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/OliveTin

FEDORA-2022-1a837ff586 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-1a837ff586

FEDORA-2022-1a837ff586 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.