Spec URL: https://raw.githubusercontent.com/amoralej/packages/main/python-uhashring.spec SRPM URL: https://github.com/amoralej/packages/raw/main/python-uhashring-2.1-1.fc38.src.rpm Description: Upstream project: https://github.com/ultrabug/uhashring uhashring implements consistent hashing in pure Python. Consistent hashing is mostly used on distributed systems/caches/databases as this avoid the total reshuffling of your key-node mappings when adding or removing a node in your ring (called continuum on libketama). This package is required for python-binary-memcached which i will add later. Fedora Account System Username: amoralej
pyproject-rpm-macros BR is not required here
There are three issues with the package: 1. The package is not in latest version 2. Changelog is missing "-" before version 3. pyproject-rpm-macros BR is not required here Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 20 files have unknown license. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/ultrabug/uhashring/archive/refs/tags/2.1.tar.gz : CHECKSUM(SHA256) this package : 9807f780b6291b3c21a121dc929c973ae1a6335aeea0e688da9dc8fbeb64ab97 CHECKSUM(SHA256) upstream package : 9807f780b6291b3c21a121dc929c973ae1a6335aeea0e688da9dc8fbeb64ab97 Requires -------- python3-uhashring (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-uhashring: python-uhashring python3-uhashring python3.11-uhashring python3.11dist(uhashring) python3dist(uhashring) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2143910 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: R, Java, fonts, PHP, Haskell, C/C++, Perl, Ocaml, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
WRT the reported issues: 1. The package is not in latest version Latest version, 2.2 fails to build because the package was moved to hatch build system in: https://github.com/ultrabug/uhashring/commit/744f61fbd2ef71f7479dd99411627f5c512d402e The package config has been moved to pyproject.tml with a format that is not properly managed by %pyproject_wheel macro that fails with: ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found The reason is taht current tox and tox-current-env only supports pyproject.toml with legacy_tox_ini format (https://tox.wiki/en/latest/example/basic.html) while this project does not have legacy_tox_ini: https://github.com/ultrabug/uhashring/blob/master/pyproject.toml Checking the differences in code between uhashring 2.1 and 2.2: https://github.com/ultrabug/uhashring/compare/2.1...2.2 I've noticed there are no relevant changes in code and 2.1 still had the old tox.ini, setup.py files, so i decided to package 2.1 instead of reverting specific patches at packaging or other hacky solutions. 2. Changelog is missing "-" before version fixed in updated spec file Spec URL: https://raw.githubusercontent.com/amoralej/packages/main/python-uhashring.spec SRPM URL: https://github.com/amoralej/packages/raw/main/python-uhashring-2.1-1.fc38.src.rpm 3. pyproject-rpm-macros BR is not required here fixed in updated spec file
ok, in this case using not the latest version is strongly justified. Package is approved.
https://pagure.io/releng/fedora-scm-requests/issue/49241
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-uhashring
Initial import in: https://src.fedoraproject.org/rpms/python-uhashring/c/8d6166e2fc2dd7b1059c03c53ea029544937a5eb?branch=rawhide Package built in https://koji.fedoraproject.org/koji/buildinfo?buildID=2091504