Fedora Account System
Red Hat Associate
Red Hat Customer
Created attachment 1926539 [details] Fix speed calculation for high speed network interface Description of problem: For 10Gb/s network interface, `get_speed_duplex` returns wrong speed because of overflow. Things get worse for 200Gb/s interface, as `ethtool_cmd.speed_hi` field was ignored. Version-Release number of selected component (if applicable): How reproducible: 100% Steps to Reproduce: 1.run nicstat to monitor network read and write usage of 10Gb or 200Gb interface 2. 3. Actual results: Wrong rUtil and wUtil are reported because of wrong speed returned by function `get_speed_duplex`. Expected results: Additional info: Patch for this issue. ``` diff --git a/nicstat.c b/nicstat.c index 83ad557..2b52c39 100644 --- a/nicstat.c +++ b/nicstat.c @@ -1587,6 +1587,7 @@ get_speed_duplex(nicdata_t *nicp) struct ifreq ifr; struct ethtool_cmd edata; int status; + unsigned long long speed; if (nicp->flags & NIC_NO_GSET) { if (nicp->speed > 0) @@ -1609,7 +1610,8 @@ get_speed_duplex(nicdata_t *nicp) get_speed_duplex(nicp); return; } - nicp->speed = edata.speed * 1000000; + speed = (((unsigned)edata.speed_hi) << 16) + edata.speed; + nicp->speed = speed * 1000000; nicp->duplex = edata.duplex; } ```
This message is a reminder that Fedora Linux 36 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 36 on 2023-05-16. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '36'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 36 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
This bug appears to have been reported against 'rawhide' during the Fedora Linux 39 development cycle. Changing version to 39.
This message is a reminder that Fedora Linux 39 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 39 on 2024-11-26. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '39'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 39 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle. Changing version to 42.
This message is a reminder that Fedora Linux 42 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora Linux 42 on 2026-05-13. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a 'version' of '42'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, change the 'version' to a later Fedora Linux version. Note that the version field may be hidden. Click the "Show advanced fields" button if you do not see it. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora Linux 42 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora Linux, you are encouraged to change the 'version' to a later version prior to this bug being closed.
FEDORA-2026-0ca6e85ae6 (nicstat-1.95-28.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-0ca6e85ae6
FEDORA-2026-0ca6e85ae6 (nicstat-1.95-28.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-663cf5fbc6 (nicstat-1.95-28.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-663cf5fbc6
FEDORA-2026-663cf5fbc6 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-663cf5fbc6` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-663cf5fbc6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-663cf5fbc6 (nicstat-1.95-28.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.