Bug 2145116 - Review Request: rust-serde-sarif - Serde serialization for SARIF files
Summary: Review Request: rust-serde-sarif - Serde serialization for SARIF files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2064470
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-11-23 08:34 UTC by Jan Macku
Modified: 2023-08-09 02:31 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-09 01:31:06 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Jan Macku 2022-11-23 08:34:07 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-serde-sarif/fedora-rawhide-x86_64/06225079-rust-serde-sarif/rust-serde-sarif.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jamacku/rust-serde-sarif/fedora-rawhide-x86_64/06225079-rust-serde-sarif/rust-serde-sarif-0.4.1-1.fc39.src.rpm
Description: This package contains library source intended for building other packages which use the "serde-sarif" crate
Fedora Account System Username: jamacku

Comment 1 blinxen 2023-05-29 21:07:36 UTC
Do you still need this package? The provided URLs result in a 404.

Comment 2 Jan Macku 2023-05-30 07:05:30 UTC
@(In reply to blinxen from comment #1)
> Do you still need this package? The provided URLs result in a 404.

Yes, I still want to package this crate into Fedora. Thanks for letting me know. I'll update the links as soon as possible.

Comment 3 Michel Lind 2023-07-11 21:00:50 UTC
Still 404 by the way

Comment 4 Jan Macku 2023-07-19 12:47:29 UTC
I'm sorry that it is taking that long. I checked the upstream, and they are using some outdated dependencies. So I cannot provide a scratch build for review at the moment.

Problem: nothing provides requested (crate(prettyplease/default) >= 0.1.24 with crate(prettyplease/default) < 0.2.0~)

I have noticed upstream, I'll try to provide a review build as soon as possible.

Comment 5 Jan Macku 2023-07-31 12:24:56 UTC
I was able to build the package with the latest upstream release finally. I'm sorry for the delay.

The links should be up to date and ready to review.

Thank you.

Comment 6 Fabio Valentini 2023-07-31 12:58:28 UTC
Thanks for the update! Looks good to me. And sorry this has taken so long!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Jan Macku 2023-07-31 13:54:07 UTC
No worries. Thank you for the quick review Fabio.

Comment 8 Fedora Admin user for bugzilla script actions 2023-07-31 14:03:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde-sarif

Comment 9 Fedora Update System 2023-07-31 16:00:33 UTC
FEDORA-2023-7c01d1292f has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7c01d1292f

Comment 10 Fedora Update System 2023-07-31 16:01:23 UTC
FEDORA-2023-b9e6284e97 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9e6284e97

Comment 11 Fedora Update System 2023-08-01 01:41:52 UTC
FEDORA-2023-7c01d1292f has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7c01d1292f`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7c01d1292f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-08-01 01:50:58 UTC
FEDORA-2023-b9e6284e97 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b9e6284e97`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b9e6284e97

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-08-09 01:31:06 UTC
FEDORA-2023-7c01d1292f has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-08-09 02:31:44 UTC
FEDORA-2023-b9e6284e97 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.