Bug 2145144 - libxtables: Revert change to struct xtables_pprot
Summary: libxtables: Revert change to struct xtables_pprot
Keywords:
Status: MODIFIED
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: iptables
Version: 8.8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.8
Assignee: Phil Sutter
QA Contact: Jiri Peska
URL:
Whiteboard:
Depends On:
Blocks: 2221107
TreeView+ depends on / blocked
 
Reported: 2022-11-23 10:53 UTC by Phil Sutter
Modified: 2023-07-07 09:54 UTC (History)
4 users (show)

Fixed In Version: iptables-1.8.5-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2221107 (view as bug list)
Environment:
Last Closed:
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-140272 0 None None None 2022-11-23 10:53:51 UTC

Description Phil Sutter 2022-11-23 10:53:18 UTC
One of the backports for Bug 2058444 introduced libxtables ABI breakage, fix
this by backporting the following commit:

commit a7c2b7289cd31455b854fee7d5c735c6270518a3
Author: Phil Sutter <phil>
Date:   Fri May 6 00:11:47 2022 +0200

    libxtables: Revert change to struct xtables_pprot

    While protocol values may exceed eight bits, the data structure is
    indeed used only to store the static list of name/value pairs for faster
    lookups. None of those has such a value and if one is added in future,
    the compiler will complain about it.

    So restore the old field type to retain binary compatibility.

    Fixes: 556f704458cdb ("Use proto_to_name() from xshared in more places")
    Signed-off-by: Phil Sutter <phil>

RHEL9 is unaffected, RHEL8.6 has the fix already via Bug 2137953, RHEL8.7 needs
to be fixed as well.

Comment 4 Phil Sutter 2023-07-07 09:54:33 UTC
Marking as TestOnly since the fix is already contained in backports for bug 2211063.

Given the fact that there is no functional change (unless crafted by custom code relying upon the data structure layout), sanity only testing probably suffices.


Note You need to log in before you can comment on or make changes to this bug.