+++ This bug was initially created as a clone of Bug #2141741 +++ We gonna need to get python-observabilityclient to OSP distribution (and to whatever undercloud is using as image). RDO upstream packaging will be provided soon. [1] https://github.com/infrawatch/python-observabilityclient --- Additional comment from Emma Foley on 2022-11-22 17:17:33 UTC --- I've created the initial review to create the add the project to rdo. I believe we're supposed to do a licence review first, but it's all linked anyway. https://review.rdoproject.org/r/c/rdoinfo/+/46177 --- Additional comment from Alfredo Moralejo on 2022-11-23 09:07:34 UTC --- May you create a clone of this bz for RDO instead of OSP? example https://bugzilla.redhat.com/show_bug.cgi?id=1748791
$ licensecheck -r . ./LICENSE: *No copyright* Apache License 2.0 ./README.rst: *No copyright* UNKNOWN ./setup.cfg: *No copyright* Apache License ./setup.py: Apache License 2.0 ./observabilityclient/plugin.py: *No copyright* UNKNOWN ./observabilityclient/utils/runner.py: Apache License 2.0 ./observabilityclient/utils/shell.py: Apache License 2.0 ./observabilityclient/utils/strings.py: Apache License 2.0 ./observabilityclient/v1/base.py: Apache License 2.0 ./observabilityclient/v1/deploy.py: Apache License 2.0 License is valid ASL 2.0
Upstream development has been halted, so we don't need packaging anymore.
Reopened as it is required now for aodh project. https://review.rdoproject.org/r/c/openstack/observabilityclient-distgit/+/50786
The actual upstream repo is in https://opendev.org/openstack/python-observabilityclient licensecheck $ licensecheck -r . ./.gitreview: *No copyright* UNKNOWN ./.zuul.yaml: *No copyright* UNKNOWN ./AUTHORS: *No copyright* UNKNOWN ./LICENSE: *No copyright* Apache License 2.0 ./README.md: *No copyright* UNKNOWN ./pyproject.toml: *No copyright* UNKNOWN ./requirements.txt: *No copyright* UNKNOWN ./setup.cfg: *No copyright* Apache License ./setup.py: Apache License 2.0 ./tox.ini: *No copyright* UNKNOWN ./observabilityclient/client.py: Apache License 2.0 ./observabilityclient/i18n.py: Apache License 2.0 ./observabilityclient/plugin.py: Apache License 2.0 ./observabilityclient/prometheus_client.py: Apache License 2.0 ./tools/install_deps.sh: *No copyright* UNKNOWN ./observabilityclient/utils/metric_utils.py: Apache License 2.0 ./observabilityclient/v1/base.py: Apache License 2.0 ./observabilityclient/v1/cli.py: Apache License 2.0 ./observabilityclient/v1/client.py: Apache License 2.0 ./observabilityclient/v1/python_api.py: Apache License 2.0 ./observabilityclient/v1/rbac.py: Apache License 2.0 ./observabilityclient/tests/unit/test_cli.py: Apache License 2.0 ./observabilityclient/tests/unit/test_prometheus_client.py: Apache License 2.0 ./observabilityclient/tests/unit/test_python_api.py: Apache License 2.0 ./observabilityclient/tests/unit/test_rbac.py: Apache License 2.0 ./observabilityclient/tests/unit/test_utils.py: Apache License 2.0 License is valid Apache License 2.0
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0". 15 files have unknown license. Detailed output of licensecheck in /tmp/python- observabilityclient/licensecheck.txt [?]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [-]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1839 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-observabilityclient , python3-observabilityclient-tests [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify occurs outside of %prep. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define upstream_version 0.1.1.dev4 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-observabilityclient-0.1.1-0.20231113131448.d0b868d.el9.noarch.rpm python3-observabilityclient-tests-0.1.1-0.20231113131448.d0b868d.el9.noarch.rpm python-observabilityclient-0.1.1-0.20231113131448.d0b868d.el9.src.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp0aln6uyj')] checks: 31, packages: 3 python3-observabilityclient.noarch: W: obsolete-not-provided python39-observabilityclient python3-observabilityclient-tests.noarch: W: obsolete-not-provided python39-observabilityclient-tests python3-observabilityclient-tests.noarch: W: no-documentation python-observabilityclient.src: E: no-changelogname-tag python3-observabilityclient.noarch: E: no-changelogname-tag python3-observabilityclient-tests.noarch: E: no-changelogname-tag python-observabilityclient.spec:62: W: macro-in-comment %{service} python-observabilityclient.spec: W: invalid-url Source0: python-observabilityclient-0.1.1.dev4-0.20231113131448.d0b868d.tar.gz python-observabilityclient.src: E: description-line-too-long This is an OpenStackClient (OSC) plugin that implements commands for management of Prometheus. python3-observabilityclient.noarch: E: description-line-too-long This is an OpenStackClient (OSC) plugin that implements commands for management of Prometheus. python3-observabilityclient-tests.noarch: E: description-line-too-long This is an OpenStackClient (OSC) plugin that implements commands for management of Prometheus. ==================================================== 3 packages and 0 specfiles checked; 6 errors, 5 warnings, 6 badness; has taken 0.5 s ====================================================
wrt no-changelogname-tag and invalid-url - that's expected for DLRN packages. But it would be good to fix E: description-line-too-long.
description-line-too-long error fixed in https://review.rdoproject.org/r/c/openstack/observabilityclient-distgit/+/50809
This package is included now in Bobcat and Antelope.