Red Hat Bugzilla – Bug 214542
netpoll_send_udp does not compute a UDP checksum
Last modified: 2007-11-30 17:07:36 EST
Description of problem:
netpoll_send_udp would always set the UDP checksum to 0. This means that all
packets sent via netconsole (the only two users of netpoll_send_udp) would have
a zero checksum. While this is technically allowed by the protocol, this is
generally not advisable. The fix is a simple UDP checksum calculation in
Created attachment 140629 [details]
Fix to correctly compute checksum in netpoll_send_udp
version was set to rc1, patch posted on 11/08.
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release. Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products. This request is not yet committed for inclusion in an Update
This seems like the kind of thing which should be deferred to 5.1 as opposed to
taken in now. The 0 checksum is allowed by the protocol and the behavior
appears to have been this way all of RHEL5. Is this a regression relative to RHEL4?
Well, it is now :). The patch was accepted and integrated into the RHEL-4 tree
a few days ago. This has been a problem for a very long time; I checked all the
way back to the RHEL 2.1 tree, and it was a problem on all versions. It was
also just committed upstream. While a zero checksum is allowed by the protocol,
it is strongly discouraged, so the fix should go in. Also, it is a pretty
trivial fix, so the chance for regression is very slim. That being said, it is
not *critical*, so it can be deferred if QA can't get to it.
QE ack for RHEL5.
A package has been built which should help the problem described in
this bug report. This report is therefore being closed with a resolution
of CURRENTRELEASE. You may reopen this bug report if the solution does
not work for you.