Bug 214598 - dbus interface misnamed
Summary: dbus interface misnamed
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: hal-cups-utils
Version: 5.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
: ---
Assignee: Tim Waugh
QA Contact:
URL:
Whiteboard:
Depends On: 214623
Blocks: 214599
TreeView+ depends on / blocked
 
Reported: 2006-11-08 16:07 UTC by Matthias Clasen
Modified: 2007-11-30 22:07 UTC (History)
3 users (show)

Fixed In Version: 5.0.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-11-28 21:32:32 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
hal-cups-utils-introspection.patch (693 bytes, patch)
2006-11-08 17:39 UTC, Tim Waugh
no flags Details | Diff

Description Matthias Clasen 2006-11-08 16:07:20 UTC
10-hal_lpadmin.fdi must use the interface name expected by eggcups, which is
org.freedesktop.Hal.Device.Printer, not com.redhat.Hal.Device.Printer

Comment 1 Tim Waugh 2006-11-08 16:10:26 UTC
Taking ownership.

Comment 2 RHEL Program Management 2006-11-08 16:27:21 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux release.  Product Management has requested further review
of this request by Red Hat Engineering.  This request is not yet committed for
inclusion in release.

Comment 3 James Laska 2006-11-08 16:37:52 UTC
By using the incorrect iface name ... what breaks?

Comment 4 Tim Waugh 2006-11-08 16:42:07 UTC
When a USB printer is connected, if we don't have an exact model match in the
database the user is prompted to select one.  What breaks is that after that,
nothing happens.  The user is prompted, but no printer is configured.

Comment 5 James Laska 2006-11-08 16:49:17 UTC
Thanks for the details Tim.  After discussing with Desktop QA (rousseau) ...
QE_ACK for beta2

Comment 6 Matthias Clasen 2006-11-08 16:57:09 UTC
Steps to reproduce:

1) plug in a usb  printer for which foomatic does not contain an exactly matching 
   driver, in my case it was an Epson Stylus CX7800

2) wait for the driver selection dialog to come up

3) select the best-matching driver and press ok

4) start system-config-printer and expect to see the newly added printer

result: the newly added printer is not there


Comment 7 Matthias Clasen 2006-11-08 16:59:27 UTC
Another fix that is needed in that fdi_file is that according to davidz, we need
to add 

<append key="org.freedesktop.Hal.Device.Printer.method_argnames"
type="strlist">make model</append>

to make introspection work for the interface.

Comment 8 Matthias Clasen 2006-11-08 17:29:19 UTC
ok, I have it working now. The one thing I was missing was that eggcups _does_
have a patch to use com.redhat.Hal, too. But that just doesn't work. So eggcups
needs to be reverted to use org.freedesktop.Hal too.

Comment 9 Tim Waugh 2006-11-08 17:39:32 UTC
Created attachment 140678 [details]
hal-cups-utils-introspection.patch

Introspection patch.

Comment 10 Tim Waugh 2006-11-08 18:33:47 UTC
Fixed in package is hal-cups-utils-0.6.2-5.

Comment 11 Tim Waugh 2006-11-08 18:35:09 UTC
Also requires desktop-printing-0.19-17.1.el5 for bug #214623.

Comment 13 James Laska 2006-11-08 18:49:02 UTC
Okay, pulling in the new desktop-printing package will require additional scrubbing.

That package includes bug#214623 and bug#212763 which are *not* on the
blocker-beta list.  

Comment 14 Matthias Clasen 2006-11-08 19:09:34 UTC
2146232 is part of this bug, if you read it

212763 is necessary to have working print feedback on the desktop. Isn't that
covered by the release critera ?


Note You need to log in before you can comment on or make changes to this bug.