Bug 214751 - Review Request: xview - XView widget libraries
Summary: Review Request: xview - XView widget libraries
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Package Reviews List
URL:
Whiteboard: NotReady
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-11-09 09:58 UTC by Christian Iseli
Modified: 2010-04-29 08:12 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-04-29 08:12:21 UTC
Type: ---


Attachments (Terms of Use)
Patch with some interesting fixes from Suse (7.25 KB, patch)
2006-11-09 19:21 UTC, Hans de Goede
no flags Details | Diff
Patch fixing a bunch of warnings (248.43 KB, patch)
2006-11-09 19:22 UTC, Hans de Goede
no flags Details | Diff
Patch: add some missing prototypes fixing a few 64 bit related warnings (but 64 bit is still nogo) (4.70 KB, patch)
2006-11-09 19:23 UTC, Hans de Goede
no flags Details | Diff

Description Christian Iseli 2006-11-09 09:58:07 UTC
Spec URL: ftp://ftp.licr.org/pub/xview.spec
SRPM URL: ftp://ftp.licr.org/pub/xview-3.2-0.1.p4.src.rpm
Description:
XView (X Window-System-based Visual/Integrated Environment for Workstations)
is a user-interface toolkit to support interactive, graphics-based
applications running under the X Window System.  XView provides a set of
pre-built, user-interface objects such as canvases, scrollbars, menus, and
control panels.  The appearance and functionality of these objects follow
the OPEN LOOK Graphical User Interface (GUI) specification.  XView features
an object-oriented style Application Programmer's Interface (API) that is
straightforward and easy to learn.

This is pretty much vintage stuff :-)

There are a few useful pieces of scientific software that depend on the xview package.  I intend to submit some of them over time, starting with treetool.

This review request is to get the ball rolling.  Some discussion already occured on f-e-l: https://www.redhat.com/archives/fedora-extras-list/2006-October/msg00643.html

It looks like we will have to exclude 64-bit architectures for now, and use the 32-bit packages on x86_64.

Hans, please add your patches to this ticket...  tia :-)

Comment 1 Patrice Dumas 2006-11-09 10:11:03 UTC
Maybe it would be interesting to submit treetool before the 
review is completed such that we can test that xview works 
correctly on treetools, otherwise there is no test case.

I'll follow the review, but I'd like to avoid formally reviewing 
the package for obvious reasons...

Comment 2 Christian Iseli 2006-11-09 10:16:11 UTC
(In reply to comment #1)
> Maybe it would be interesting to submit treetool before the 
> review is completed such that we can test that xview works 
> correctly on treetools, otherwise there is no test case.

Will do ASAP.  I'm currently waiting for the OA to clarify the license terms
(he already said in PM he has no problem to put this in FE, but hasn't decided
yet which exact license to use)...

In the meantime, there are a few clients (cmdtool, shelltool, clock) already
included in the xview package.

> I'll follow the review, but I'd like to avoid formally reviewing 
> the package for obvious reasons...

Sure, np.  Thanks for putting it together in the first place.

Comment 3 Hans de Goede 2006-11-09 19:21:09 UTC
Created attachment 140809 [details]
Patch with some interesting fixes from Suse

I've spend some hours taking a look and I've come to the same conclusion
as the Debian maintainer, this is very hard to fix for 64 bit. More then
that fixing probably will also include fixing / changing all xview using
clients!

Luckily all 64 bit platforms we support also have a 32 bit compatibility
option, so I think we should just not build xview (and apps using it)
for x86_64 / ppc64. It would be a good idea IMHO in cases like this to
add xview + deps + packages using it to a list of packages to copy over
to the x86_64 repo from the i386 repo, so that it will be readily
available for those who want it.

My taking a look started with suse since they had x86_64 packages of
xview in their repo, but appearantly these have had the famous suse QA
done do them (iow none). I did find some other interesting patches in
there, which I have bundled in a smaller one with possible real fixes
and a larger one which fixes a load of warnings (but no where near all
warnings). I also have a patch which fixes some 64 bit related warnings
by adding the necessary prototypes, which isn't enough to get this
running but IMHO still should be applied / send upstream (Debian claims
to be upstream these days) as it is an improvement.

Comment 4 Hans de Goede 2006-11-09 19:22:02 UTC
Created attachment 140810 [details]
Patch fixing a bunch of warnings

Comment 5 Hans de Goede 2006-11-09 19:23:05 UTC
Created attachment 140811 [details]
Patch: add some missing prototypes fixing a few 64 bit related warnings (but 64 bit is still nogo)

Comment 6 Xavier Lamien 2007-06-10 00:28:30 UTC
Christian ping ?

Comment 7 Christian Iseli 2007-06-10 08:11:11 UTC
yea, I'm still here... but haven't had any time to work on this.
But there's hope...

Are you interested in helping ?


Comment 8 Christian Iseli 2007-06-11 12:47:32 UTC
Ok, I made some progress.  New SRPM and spec here:
ftp://ftp.licr.org/pub/xview.spec
ftp://ftp.licr.org/pub/xview-3.2p1.4-0.fc7.src.rpm

I still haven't heard back from the treetool maintainer (and poked him again,
we'll see).
In the meantime: any idea which xview-using package would be suitable as guinea
pig?  I thought about workman, but I don't think anyone would actually use it :-)

This thing compiles and runs on i386 (and probably ppc) in 32 bit.  There are
still quite a few worrisome compiler warnings.  And much more work to get it to
run on 64-bit machines.  I didn't see any progress in Debian on this front.

rpmlint seems mostly happy

I'd still like to clean it up further, but this is where I got so far and it
might already be useful to other folks as-is...

Thanks to Hans for all the work he put into this already.

Of course, if anyone is interested in co-maintaining, I'd be delighted


Comment 9 Xavier Lamien 2007-06-11 17:26:35 UTC
[in reply to comment #7]
>> Are you interested in helping ?
yes. ;-)


okay, i'll check this out on x86_64.

Comment 10 Jason Tibbitts 2007-11-19 04:34:26 UTC
This ticket is now over a year old; is it dead yet?  Or is there still interest
in moving it forward?

Comment 11 Christian Iseli 2007-11-19 08:02:41 UTC
(In reply to comment #10)
> This ticket is now over a year old; is it dead yet?

Not, dead... just in deep slumber :)

> Or is there still interest in moving it forward?

I'm still interested to see this in, somehow.


Comment 12 Jason Tibbitts 2007-11-19 19:59:19 UTC
So what needs to happen?  I mean, you could use ExclusiveArch: i386 (and maybe
ppc too) but that seems somewhat pointless.

There are a few other things that would need to be fixed: "Distributable" is
never OK for a License: and you'd need to remove or split off the static libraries.

Comment 13 Christian Iseli 2007-11-19 21:17:01 UTC
(In reply to comment #12)
> So what needs to happen?  I mean, you could use ExclusiveArch: i386 (and maybe
> ppc too) but that seems somewhat pointless.
> 
> There are a few other things that would need to be fixed: "Distributable" is
> never OK for a License: and you'd need to remove or split off the static
libraries.

That sort of went under the radar for a while now.  But I'll try to find some
time and clean up the mess a bit.

I wanted to take a second hard look to see if it would be feasible to make this
64-bit clean...  but I could start with a bunch of ExcludeArch.

The thing is that if I distribute a 32-bit only package first, things will
probably break when the code is cleaned for 64-bits.  So I'm a bit hesitant...


Comment 14 Jason Tibbitts 2008-01-27 20:27:14 UTC
I guess it's time to ping on this old ticket.  Has there been any progress?

Comment 15 Christian Iseli 2008-01-28 08:34:38 UTC
No progress: -ENOTIME...

I still intend to get back to it when time permits.  If you'd rather see this
one closed, I can always reopen a new one when I'm ready.


Comment 16 Jason Tibbitts 2008-01-28 18:26:46 UTC
All I can say is that as long as this ticket is open, I'll keep pinging it.  So
if you'd like a reminder ever couple of months then sure, leave it open.

Comment 17 Christian Iseli 2008-01-28 22:29:13 UTC
(In reply to comment #16)
> So if you'd like a reminder ever couple of months then sure, leave it open.

Fine with me :-)


Comment 18 Jason Tibbitts 2008-04-04 21:45:05 UTC
Well, I promised I'd ping every couple of months, and I'm about a week late. 
Any progress?

Comment 19 Christian Iseli 2008-04-07 13:18:19 UTC
No progress... (gee, time flies...)


Comment 20 Christian Iseli 2008-10-22 22:03:41 UTC
Still no progress...

Comment 21 Caius Chance 2009-02-17 06:04:05 UTC
ping :)

Comment 22 Christian Iseli 2009-02-17 09:00:35 UTC
Still here and still haven't lost interest, and doing my best not to lose hope...

Comment 23 Susi Lehtola 2009-07-16 11:44:31 UTC
spec url doesn't work.

Comment 24 Christian Iseli 2009-07-16 12:11:41 UTC
(In reply to comment #23)
> spec url doesn't work.  

Strange.  Works for me...
From where are you trying to access it, and what exactly happens ?

Comment 25 Susi Lehtola 2009-07-16 12:26:35 UTC
(In reply to comment #24)
> (In reply to comment #23)
> > spec url doesn't work.  
> 
> Strange.  Works for me...
> From where are you trying to access it, and what exactly happens ?  

Okay, that was a problem with Chromium. With Firefox it works fine.

(I'm still waiting for ftp servers to vanish from the face of the earth, as well as any other protocols that aren't firewall safe.)

Comment 26 Christian Iseli 2009-07-16 13:12:12 UTC
(In reply to comment #25)
> (I'm still waiting for ftp servers to vanish from the face of the earth, as
> well as any other protocols that aren't firewall safe.)  

eh ... :-)

Comment 27 Caius Chance 2010-04-29 01:05:19 UTC
Ping? I would suggest to close this ticket.

Comment 28 Christian Iseli 2010-04-29 08:12:21 UTC
(In reply to comment #27)
> Ping? I would suggest to close this ticket.    

Ok.  Still haven't found enough time to work on this unfortunately.


Note You need to log in before you can comment on or make changes to this bug.