Bug 2148560 - Review Request: rust-trybuild2 - Test harness for ui tests of compiler diagnostics
Summary: Review Request: rust-trybuild2 - Test harness for ui tests of compiler diagno...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-11-25 22:30 UTC by Kalev Lember
Modified: 2022-11-28 16:00 UTC (History)
2 users (show)

Fixed In Version: rust-trybuild2-1.0.0-1.fc38 rust-trybuild2-1.0.0-1.fc37 rust-trybuild2-1.0.0-1.fc36
Clone Of:
Environment:
Last Closed: 2022-11-28 15:48:31 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2022-11-25 22:30:23 UTC
Spec URL: https://kalev.fedorapeople.org/rust-trybuild2.spec
SRPM URL: https://kalev.fedorapeople.org/rust-trybuild2-1.0.0-1.fc38.src.rpm
Description:
Test harness for ui tests of compiler diagnostics (with support for inline
tests).

Fedora Account System Username: kalev

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=94545055

Comment 1 Fabio Valentini 2022-11-28 13:10:57 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please also request f37 and f36 branches for this package.

Comment 2 Gwyn Ciesla 2022-11-28 15:37:03 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trybuild2

Comment 3 Kalev Lember 2022-11-28 15:48:31 UTC
Thanks, Fabio! I requested all the branches and builds are under way.

Comment 4 Fedora Update System 2022-11-28 15:59:39 UTC
FEDORA-2022-e0fcaa9252 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e0fcaa9252

Comment 5 Fedora Update System 2022-11-28 16:00:23 UTC
FEDORA-2022-e0fcaa9252 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.