Red Hat Bugzilla – Bug 214985
Review Request: pachi - Pachi El Marciano - Platform Game
Last modified: 2007-11-30 17:11:48 EST
Spec URL: http://people.atrpms.net/~hdegoede/pachi.spec
SRPM URL: http://people.atrpms.net/~hdegoede/pachi-1.0-1.src.rpm
Pachi El Marciano is a cool 2D platform game inspired by the likes of
Manic Miner, Jet Set Willy, and more from the '80s.
Will do a full review later this evening, but quick question: why is the Pachi
binary SUID root? I've not had time to test it much, but the game starts and
acts normally when I removed its SUID bit.
(one rpmlint error on the binary from this)
It isn't suid root, its sgid games, unless something has gone wrong.
Almost done - building my mock cache so I can rebuild the package in mock. Last
question: where is ImageMagick used in the build process?
spec name OK
spec language OK
spec readability OK
source verification OK
compilation (x86_64) OK
files & directory ownerships OK
icon cache updated on post & postun OK
- SGID dropped once score file opened OK
Package works OK in mock.
APPROVED (though I'm still curious where ImageMagick is used)
ImageMagick is needed for the convert command, which is used to convert the .ico
file to a png file.
Thanks for the review! Imported and build, closing.