RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2150107 - Classification banner shows on top of windows
Summary: Classification banner shows on top of windows
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: gnome-shell-extensions
Version: 8.7
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Florian Müllner
QA Contact: Michael Boisvert
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-01 20:50 UTC by Andrew Mike
Modified: 2023-05-16 09:58 UTC (History)
11 users (show)

Fixed In Version: gnome-shell-extensions-3.32.1-31.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-16 08:37:43 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screenshot of the issue (note that the banner obscures one line of the terminal, the scroll bar, etc) (22.86 KB, image/png)
2022-12-01 20:50 UTC, Andrew Mike
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-141082 0 None None None 2022-12-01 21:02:41 UTC
Red Hat Product Errata RHBA-2023:2840 0 None None None 2023-05-16 08:37:54 UTC

Description Andrew Mike 2022-12-01 20:50:04 UTC
Created attachment 1929132 [details]
screenshot of the issue (note that the banner obscures one line of the terminal, the scroll bar, etc)

Description of problem: When the classification banner is enabled, it shows on top of windows, preventing input.


Version-Release number of selected component (if applicable):
gnome-shell-extension-classification-banner-3.32.1-29.el8

How reproducible: 100%

Steps to Reproduce:
1. Install the GUI and the classification banner:
# dnf group install "Server with GUI"
# dnf install gnome-shell-extension-classification banner

2. Make the file /etc/dconf/db/local.d/99-banner and populate it with the following:

[org/gnome/shell]
enabled-extensions=['classification-banner.github.com']

[org/gnome/shell/extensions/classification-banner]
background-color='rgba(0,119,51,0.75)'
message='UNCLASSIFIED'
top-banner=true
bottom-banner=true
system-info=false
color='white'

3. Update the dconf database:

# dconf refresh

4. Start the GUI:

# systemctl isolate graphical.target

5. Log in and open the Terminal app.
6. Select View > Fullscreen from the menu.

Actual results: Classification banner draws on top of the terminal, obscuring part of the terminal working area (see attached screenshot).

Expected results: Banner should be places outside of the GUI working area and fullscreen applications should fill the space in between the banners.

Additional info: This also happens on RHEL 9.1 (extension version 40.7-2.el9).

Comment 1 Florian Müllner 2022-12-01 21:45:16 UTC
(In reply to Andrew Mike from comment #0)
> Description of problem: When the classification banner is enabled, it shows
> on top of windows, preventing input

That is expected. The extensions is meant as a replacement for https://github.com/SecurityCentral/classification-banner, which has the same behavior.

The banner doesn't take input though, so elements underneath it should still be clickable.

> Classification banner draws on top of the terminal, obscuring part of the terminal working area (see attached screenshot).

IMHO the only bug there is that the position isn't adjusted to the hidden top bar. Alternatively we could hide the banner altogether if an app is in fullscreen, although I'm not sure that that wouldn't defy its purpose.


> Banner should be places outside of the GUI working area and fullscreen applications should fill the space in between the banners.

That's not possible without changes in mutter's window management code. We would essentially need a special struts type that still applies to fullscreen windows (unlikely regular struts that are used by the top bar and 3rd party docks/panels). That's too intrusive and won't happen.

Comment 2 Andrew Mike 2022-12-07 21:37:27 UTC
(In reply to Florian Müllner from comment #1)
> The banner doesn't take input though, so elements underneath it should still
> be clickable.

Confirmed in testing, but the banner still obscures part of the window when set to full opacity.

> IMHO the only bug there is that the position isn't adjusted to the hidden
> top bar.

Not sure what you mean by this, could you clarify? Which hidden top bar are you referring to?

> Alternatively we could hide the banner altogether if an app is in
> fullscreen, although I'm not sure that that wouldn't defy its purpose.

I discussed this with my customer, and hiding the banner would not be desirable behavior.

Comment 3 Florian Müllner 2022-12-09 14:13:05 UTC
(In reply to Andrew Mike from comment #2)
> (In reply to Florian Müllner from comment #1)
> > The banner doesn't take input though, so elements underneath it should still
> > be clickable.
> 
> Confirmed in testing, but the banner still obscures part of the window when
> set to full opacity.

Correct, this is expected behavior.


> > IMHO the only bug there is that the position isn't adjusted to the hidden
> > top bar.
> 
> Not sure what you mean by this, could you clarify? Which hidden top bar are
> you referring to?

The black bar with "Activities", clock and system status that gnome-shell puts on top of the screen.

The classification banner is placed underneath that bar, and doesn't change its position when a window is in fullscreen (and the top bar is therefore hidden). That is, it should be placed at the very top of the monitor, not offset by ~25 pixels.


> > Alternatively we could hide the banner altogether if an app is in
> > fullscreen, although I'm not sure that that wouldn't defy its purpose.
> 
> I discussed this with my customer, and hiding the banner would not be
> desirable behavior.

Right, I'm not surprised by this.

But I'm afraid that for fullscreen, the realistic alternatives for classification banners are hiding or overlap.

Comment 4 Andrew Mike 2022-12-14 14:27:54 UTC
I see. In that case, can we make sure the banner is at the top of the screen when using a fullscreen application?

Comment 5 Florian Müllner 2022-12-14 15:53:55 UTC
We can and we should.

Comment 6 Michael Boisvert 2022-12-14 16:21:08 UTC
Would a fullscreen window with the banner above it reveal the top bar hidden beneath it?

Comment 7 Florian Müllner 2022-12-14 16:59:33 UTC
(In reply to Michael Boisvert from comment #6)
> Would a fullscreen window with the banner above it reveal the top bar hidden
> beneath it?

No, the banner would still be overlaid on top of the window like it is now, just at a slightly different position.

Comment 8 Michael Boisvert 2022-12-17 01:34:12 UTC
Using gnome-shell-extensions-3.32.1-31.el8, the classification banner is moved up 25 pixels when an application is switched into fullscreen mode.

Comment 15 errata-xmlrpc 2023-05-16 08:37:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (gnome-shell-extensions bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:2840


Note You need to log in before you can comment on or make changes to this bug.