Bug 2150511 - Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust
Summary: Review Request: rust-kamadak-exif - Exif parsing library written in pure Rust
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/kamadak-exif
Whiteboard:
Depends On: 2150509
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-03 15:26 UTC by Kalev Lember
Modified: 2023-04-02 22:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-04-02 22:16:26 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Kalev Lember 2022-12-03 15:26:29 UTC
Spec URL: https://kalev.fedorapeople.org/rust-kamadak-exif.spec
SRPM URL: https://kalev.fedorapeople.org/rust-kamadak-exif-0.5.5-1.fc38.src.rpm
Description:
Exif parsing library written in pure Rust.

Fedora Account System Username: kalev

Comment 1 Kalev Lember 2023-03-23 22:04:43 UTC
OK, rust-mutate_once is now imported, which unblocks this. Upstream has nicely added a LICENSE file in the mean time so I've gone ahead and copied it downstream as well.

* Thu Mar 23 2023 Kalev Lember <klember> - 0.5.5-2
- Add missing LICENSE file from upstream

Spec URL: https://kalev.fedorapeople.org/rust-kamadak-exif.spec
SRPM URL: https://kalev.fedorapeople.org/rust-kamadak-exif-0.5.5-2.fc39.src.rpm

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=99064259

Comment 2 Jakub Kadlčík 2023-03-23 22:08:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/5701847
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2150511-rust-kamadak-exif/fedora-rawhide-x86_64/05701847-rust-kamadak-exif/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-04-02 10:16:44 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora
- license file is included with %license in %files (included from upstream git)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

Please regenerate the spec file with rust2rpm v24 before importing the package.

Comment 4 Fedora Admin user for bugzilla script actions 2023-04-02 20:09:14 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-kamadak-exif

Comment 5 Kalev Lember 2023-04-02 20:15:59 UTC
Thanks for the review, Fabio! Package imported and build is under way.

> Please regenerate the spec file with rust2rpm v24 before importing the package.

Why? There are no changes in the generated spec file as much as I can see, except for the "# Generated by rust2rpm 23" comment.

Comment 6 Fabio Valentini 2023-04-02 20:25:36 UTC
(In reply to Kalev Lember from comment #5)
> Thanks for the review, Fabio! Package imported and build is under way.
> 
> > Please regenerate the spec file with rust2rpm v24 before importing the package.
> 
> Why? There are no changes in the generated spec file as much as I can see,
> except for the "# Generated by rust2rpm 23" comment.

Then it should be fine ... the only reason might be that I track packages by those comments and regenerate the oldest ones from time to time (in part because of the Fedora -> SPDX license tags thing), but rust2rpm v22+ should default to SPDX anyway.

Comment 7 Kalev Lember 2023-04-02 20:28:59 UTC
Ah, makes sense, thanks.

Comment 8 Fedora Update System 2023-04-02 20:53:53 UTC
FEDORA-2023-f1fc171396 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f1fc171396

Comment 9 Fedora Update System 2023-04-02 22:16:26 UTC
FEDORA-2023-f1fc171396 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.