Bug 2150772 - genesis-simulator: Build in C89 mode
Summary: genesis-simulator: Build in C89 mode
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: genesis-simulator
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Weimer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCExemptions
TreeView+ depends on / blocked
 
Reported: 2022-12-05 09:32 UTC by Florian Weimer
Modified: 2023-08-16 09:25 UTC (History)
2 users (show)

Fixed In Version: genesis-simulator-2.4-15.20210608git7b0a66b.fc38
Clone Of:
Environment:
Last Closed: 2022-12-05 10:22:11 UTC
Type: Bug
Embargoed:
fweimer: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github genesis-sim genesis-2.4 issues 6 0 None open Please explicitly build with -std=gnu89 (at least) so that compilation does not break when gcc/clang get more strict abo... 2022-12-05 11:57:51 UTC
Red Hat Issue Tracker FC-925 0 None None None 2023-08-16 09:25:21 UTC

Description Florian Weimer 2022-12-05 09:32:35 UTC
I looked at what it takes to port this program to C99 and away from implicit function declarations. This seems to be a major change. I started with the genesis/src/Xodus/Xo/ directory, and the sources do not use prototypes. There isn't even a shared internal header file to which function prototypes could be added. So I think this package has to be built in C89 mode. It looks like it builds just fine using that.

Comment 1 Ankur Sinha (FranciscoD) 2022-12-05 10:10:32 UTC
Hi Florian,

Thanks for looking into it.

Yeh, this is legacy software, but unfortunately, there are still models/users out there that use it. I can open an issue with upstream I guess, but I wouldn't expect any major work to happen on this any time soon (or ever).

Cheers,
Ankur

Comment 2 Florian Weimer 2022-12-05 10:22:11 UTC
(In reply to Ankur Sinha (FranciscoD) from comment #1)
> Yeh, this is legacy software, but unfortunately, there are still
> models/users out there that use it. I can open an issue with upstream I
> guess, but I wouldn't expect any major work to happen on this any time soon
> (or ever).

If you have a way to file issues upstream, please suggest that they build at least in with -std=gnu89, so that things don't stop working when GCC and Clang get more strict about enforcing C99 syntax. Thanks.

Comment 3 Ankur Sinha (FranciscoD) 2022-12-05 11:57:51 UTC
Filed an issue upstream: https://github.com/genesis-sim/genesis-2.4/issues/6


Note You need to log in before you can comment on or make changes to this bug.