Bug 2151049 - cinder::quota module is not run through puppet-tripleo
Summary: cinder::quota module is not run through puppet-tripleo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: puppet-tripleo
Version: 17.0 (Wallaby)
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ga
: 17.1
Assignee: Cédric Jeanneret
QA Contact: David Rosenfeld
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-12-06 00:48 UTC by Keigo Noha
Modified: 2023-08-16 01:13 UTC (History)
6 users (show)

Fixed In Version: puppet-tripleo-14.2.3-1.20230227001309.27145bc.el9ost
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-16 01:12:55 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 827214 0 None MERGED Cinder: Manage quota options 2022-12-06 00:48:52 UTC
OpenStack gerrit 866651 0 None MERGED Cinder: Manage quota options 2023-02-06 08:15:48 UTC
Red Hat Issue Tracker OSP-20709 0 None None None 2022-12-06 00:49:47 UTC
Red Hat Product Errata RHEA-2023:4577 0 None None None 2023-08-16 01:13:40 UTC

Description Keigo Noha 2022-12-06 00:48:52 UTC
Description of problem:
cinder::quota module is not run through puppet-tripleo.


Version-Release number of selected component (if applicable):
OSP16.1, 16.2, 17.0.

How reproducible:
Everytime when overcloud deploy is run.

Steps to Reproduce:
1. Use overcloud deploy command with cinder::quota::XXX
~~~
    ControllerExtraConfig:
        cinder::quota::quota_volumes: -1
        cinder::quota::quota_snapshots: -1
        cinder::quota::quota_backup_gigabytes: -1
        cinder::quota::quota_backups: -1
~~~
2.
3.

Actual results:
Those configurations are not reflected to cinder.conf

Expected results:
Those configurations are included into cinder.conf

Additional info:
Upstream has a fix for this issue, https://review.opendev.org/c/openstack/puppet-tripleo/+/827214.

Comment 1 Cédric Jeanneret 2022-12-06 08:22:01 UTC
Backport started for stable/wallaby: https://review.opendev.org/c/openstack/puppet-tripleo/+/866651

Manual backport for 17.0 will take place once it's merged upstream.

@knoha what's the emergency for that one? Will the CU want a hotfix, or is it OK to wait for a (potential) 17.0.2 (if we can't make it for 17.0.1)? z1 should be out on 2023-01-25. We might be able to make it on time - provided this is a blocker (17.0.1 is blocker-only since Nov 30th).

Thanks for your feedback.

Cheers,

C.

Comment 2 Takashi Kajinami 2022-12-06 08:57:53 UTC
The options can be managed by a different interface to inject arbitrary configurations (cinder::config::cinder_config),
so users can use it for now until the change is backported.

Considering the fact that we have a solid workaround, we probably better target this to RHOSP17.1 instead of RHOSP17.0,
unless we hear any reasonable concern with not having the change in OSP17.0.

Comment 3 Keigo Noha 2022-12-07 01:06:19 UTC
Hi Cedric,

As Kajinami-san said, the issue can be avoidable by using 'cinder::config::cinder_config'.
I don't know how impact we merge the fix into OSP17.0 but I respect Engineering team's decision for it because we have a concrete workaround for this issue.

Please let me know if you have any questions to me.

Best Regards,
Keigo Noha

Comment 4 Keigo Noha 2023-02-06 07:19:49 UTC
Hi Cedric,

It looks that the commit is merged into rhos-17.1-rhel-9 tree.
I think we will be able to release the fix at OSP17.1 GA. Is the expectation to the release reasonable?

Best Regards,
Keigo Noha

Comment 5 Takashi Kajinami 2023-02-06 08:17:41 UTC
The fix was already merged in stable/wallaby and has been imported to 17.1 code base so we expect the fix will be available in 17.1 GA.

Comment 11 Lukas Svaty 2023-06-16 08:13:29 UTC
Bulk moving target milestone to GA after the release of Beta on 14th June '23.

Comment 18 errata-xmlrpc 2023-08-16 01:12:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 17.1 (Wallaby)), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2023:4577


Note You need to log in before you can comment on or make changes to this bug.