Spec URL: https://lbalhar.fedorapeople.org/rust-pep440.spec SRPM URL: https://lbalhar.fedorapeople.org/rust-pep440-0.2.0-1.fc37.src.rpm Description: Parse and compare Python PEP440 style version numbers. Fedora Account System Username: lbalhar
> # Do not ship tests > rm -r %{buildroot}/%{crate_instdir}/tests Where did you get this from? In general, this is not necessary, and in some cases, doing this might even break builds of this crate as dependency of other packages. Since tests are usually just a few 100s to 1000s of bytes, we don't bother dealing with the potential for breaking things by removing the files.
Interesting, I did not know that this might break anything. I did it because one of the brp scripts failed because one of the Python scripts in tests contain a wrong shebang. I thought that there is no reason to ship tests with the package so instead of fixing or removing the shebang I've removed all the test files. Do I understand correctly that fixing the shebang is a better idea?
Yes. In this case, I think removing the tests/ directory would be fine, since the files are not referenced explicitly in Cargo.toml (i.e. the tests there are only found by cargo autodiscovery in the usual "tests" directory). But in general, just removing broken shebangs or stray executable bits should be safer, and not break builds of the crate. Or, in this case, you could just remove the "gen_test_cases.py" script (assuming it's the file with the unwanted shebang), since it's neither executed during tests, nor needed for building the crate - i.e. add `rm tests/gen_test_cases.py` between %autosetup and %cargo_prep. Doing it in %prep also ensures that if removing the file has any negative effects, they also happen during the package's build, and not only in subsequent builds of this crate as dependency of another package. Other than that, the package looks good to me, and I'll approve it once that's sorted out.
All right, thanks! Now, I'm removing the Python script in %prep before %cargo_prep.
Thanks, looks good to me now! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (BSD-2-Clause OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add the rust-sig group with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Please also request f37 and f36 branches of this package. While it might take some time to get maturin packaged, I'd like to do as much of the work to get built for all branches of Fedora up-front.
FEDORA-2022-8ec824f5c1 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8ec824f5c1
FEDORA-2022-8ec824f5c1 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-24a861ffeb has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-24a861ffeb
FEDORA-2022-24a861ffeb has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-24a861ffeb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-24a861ffeb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-405404e193 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-405404e193
FEDORA-2022-405404e193 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-405404e193 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-405404e193 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-24a861ffeb has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-405404e193 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.