Description of problem:

Plague in couple of places uses python features not in effective way. 
For example: in /www/template/main.psp
    if item != '>' and item != '<' and item != '/' and item != '\\' and item != ')' and item != '(' and item != 
"'" and item != '"' and item != '%':
           safe = safe + item

to make it more readable it could be written as:

   if item not in ('>', '<', '/', '\\', ')', '(', "'", '"', '%'):
         safe = safe + item   

or even to: safe = filter(lambda sym: sym not in ('>', '<', '/', '\\', ')', '(', "'", '"', '%'), a)


Version-Release number of selected component (if applicable): 0.4.4.1 from CVS (2006-10-25)


Additional info:

Another issues which was catched my attention in the code:

builder/builder.py
- duplicate import of time (see lines 23 and 26)
- undefined variable cur_time at line 650.
- variable build_arches  initialized in global scope, but used only in main(), would it be logical to move 
it to main() ?
- line 375: bad indentation. should be 12 spaces instead of 15.
- function log() and BuilderMock._log() uses as argument variable "string" which is equal to the module 
so, it redefines that name with different scope. maybe better to change it to "line" ? _get_mock_status() 
has almost the same issue.

- maybe at all, instead of using deprecate module "string" rewrite lines 227, 251 from:
   self._log("   %s\n" % string.join(args)) 
to 
   self._log("   %s\n" % " ".join(args))
- BuilderMock._srpm_path initialized in run(), it would be logical to initialize that variable in __init__().
- "sum" is predefined name. redefine it in XMLRPCBuilderServer._generate_uniqid() is not very good 
style.

in Config.py:
   target_dict = {} 
   target_dict['distro'] = self._distro
   target_dict['target'] = self._target 
   target_dict['arch'] = self._basearch   
   target_dict['repo'] = self._repo                                                                                

what do you think if rewrite it to bit more readable way:

  target_dict = {
    'distro': self._distro,
    'target': self._target, 
    'arch': self._basearch,   
    'repo': self._repo,                                                                               
    }
?