Bug 2152504 - openssl: C99 compatibility in downstream-only 0032-Force-fips.patch
Summary: openssl: C99 compatibility in downstream-only 0032-Force-fips.patch
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openssl
Version: rawhide
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
Assignee: Dmitry Belyavskiy
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2022-12-12 07:48 UTC by Florian Weimer
Modified: 2023-01-05 11:05 UTC (History)
8 users (show)

Fixed In Version: openssl-3.0.7-2.fc38
Clone Of:
Environment:
Last Closed: 2023-01-05 11:05:26 UTC
Type: Bug
Embargoed:
fedora-admin-xmlrpc: mirror+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 2083876 0 low CLOSED -Wimplicit-function-declaration when compiling FIPS_mode() function with clang 2023-01-05 11:11:36 UTC
Red Hat Bugzilla 2083879 0 low CLOSED -Wimplicit-function-declaration when compiling FIPS_mode() function with clang 2023-06-26 07:30:24 UTC
Red Hat Issue Tracker FC-679 0 None None None 2022-12-12 07:48:51 UTC

Internal Links: 2083879

Description Florian Weimer 2022-12-12 07:48:17 UTC
There is an implicit function declaration in provider_conf_init, currently resulting in a warning during the build:

crypto/provider_conf.c: In function 'provider_conf_init':
crypto/provider_conf.c:329:13: warning: implicit declaration of function 'EVP_default_properties_enable_fips' [-Wimplicit-function-declaration]
  329 |         if (EVP_default_properties_enable_fips(libctx, 1) != 1)
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Probably you just need to add

#include <openssl/evp.h>

to the top of the file, or add a suitable declaration of EVP_default_properties_enable_fips.

I'd appreciate if you could fix this following your patch management practices, otherwise I'll just pile on another patch for this.

Comment 1 Clemens Lang 2022-12-12 10:00:14 UTC
See also https://bugzilla.redhat.com/show_bug.cgi?id=2083879.

Comment 2 Florian Weimer 2023-01-03 15:02:20 UTC
Would it be possible to fix this, please? It impacts C99 porting of other packages.

Comment 3 Dmitry Belyavskiy 2023-01-03 15:36:28 UTC
I've already committed the updated patch but didn't fix the issue that was discovered for aarch64. Hopefully this week.

Comment 4 Fedora Update System 2023-01-05 11:04:43 UTC
FEDORA-2023-68886f4451 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-68886f4451

Comment 5 Fedora Update System 2023-01-05 11:05:26 UTC
FEDORA-2023-68886f4451 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.