Bug 2153024 - fcitx-fbterm: Calls to undeclared fcitx_client_enable_ic, fcitx_client_close_ic functions
Summary: fcitx-fbterm: Calls to undeclared fcitx_client_enable_ic, fcitx_client_close_...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: fcitx-fbterm
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orphan Owner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PortingToModernCHelpNeeded
TreeView+ depends on / blocked
 
Reported: 2022-12-13 19:38 UTC by Florian Weimer
Modified: 2022-12-16 12:06 UTC (History)
5 users (show)

Fixed In Version: fcitx-4.2.9.9-2.fc38
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-12-16 12:06:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github fcitx fcitx pull 521 0 None open fcitx-gclient: Export fcitx_client_enable_ic, fcitx_client_close_ic 2022-12-13 19:38:22 UTC

Description Florian Weimer 2022-12-13 19:38:23 UTC
The build logs and the Fedora C99 show that these functions are called without a proper previous declaration:

/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c: In function 'im_active':
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c:116:5: warning: implicit declaration of function 'fcitx_client_enable_ic'; did you mean 'fcitx_client_focus_in'? [-Wimplicit-function-declaration]
  116 |     fcitx_client_enable_ic(client);
      |     ^~~~~~~~~~~~~~~~~~~~~~
      |     fcitx_client_focus_in
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c: In function 'im_deactive':
/builddir/build/BUILD/fcitx-fbterm-0.2.0/src/fcitx-fbterm.c:126:5: warning: implicit declaration of function 'fcitx_client_close_ic'; did you mean 'fcitx_client_reset'? [-Wimplicit-function-declaration]
  126 |     fcitx_client_close_ic(client);
      |     ^~~~~~~~~~~~~~~~~~~~~
      |     fcitx_client_reset

I investigated this and it seems the proper fix is actually in fcitx: Declare these functions in the appropriate header file. I submitted a pull request to this effect:

  fcitx-gclient: Export fcitx_client_enable_ic, fcitx_client_close_ic
  <https://github.com/fcitx/fcitx/pull/521>

This bug is just a reminder to re-test fcitx-fbterm once fcitx has been updated accordingly.


Note You need to log in before you can comment on or make changes to this bug.