RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2153205 - Backport the refcounting feature from 2.58
Summary: Backport the refcounting feature from 2.58
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: glib2
Version: 8.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.8
Assignee: Michael Catanzaro
QA Contact: Tomas Pelka
URL:
Whiteboard:
Depends On:
Blocks: 2110312
TreeView+ depends on / blocked
 
Reported: 2022-12-14 09:40 UTC by Dan Horák
Modified: 2023-05-16 11:16 UTC (History)
1 user (show)

Fixed In Version: glib2-2.56.4-161.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-05-16 09:10:01 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Speculative s390-tools-grefcount.patch for 2.25.0 (3.05 KB, patch)
2022-12-14 21:20 UTC, Michael Catanzaro
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-142122 0 None None None 2022-12-14 09:50:38 UTC
Red Hat Product Errata RHBA-2023:3005 0 None None None 2023-05-16 09:10:03 UTC

Description Dan Horák 2022-12-14 09:40:04 UTC
A rebase of the s390utils package (specifically one tool there) started to use the refcounting feature that first appeared in glib 2.58, so it's not available in the RHEL-8 glib2 package which is based on 2.56. Thus I am asking to backport the recounting to RHEL-8 if possible.

my failed scratch build of s390utils is https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=49621913

Version-Release number of selected component (if applicable):
glib2-2.56.4-160.el8.s390x

Comment 2 Michael Catanzaro 2022-12-14 21:19:38 UTC
This looks easy enough to backport, so it should be no problem to do that if needed.

That said, it would probably be quicker to just patch these directly into your package. Try the attached patch. I haven't tested this yet because I couldn't figure out how to download the srpm you were working with, so it might not build, but it should be pretty close.

Comment 3 Michael Catanzaro 2022-12-14 21:20:49 UTC
Created attachment 1932724 [details]
Speculative s390-tools-grefcount.patch for 2.25.0

Comment 4 Dan Horák 2022-12-15 08:06:54 UTC
(In reply to Michael Catanzaro from comment #2)
> This looks easy enough to backport, so it should be no problem to do that if
> needed.
> 
> That said, it would probably be quicker to just patch these directly into
> your package. Try the attached patch. I haven't tested this yet because I
> couldn't figure out how to download the srpm you were working with, so it
> might not build, but it should be pretty close.

Technically this is very elegant, but I am worried about the legal implications, because you would be adding LGPL code into a MIT licensed project. Thus the backport would be my preferred solution, please.

Comment 5 Dan Horák 2022-12-15 11:46:04 UTC
Seems upstream has already solved it via https://github.com/ibm-s390-linux/s390-tools/commit/394a6dd5eacf53633efa2064a307db760902602c, thus closing.

Comment 6 Dan Horák 2022-12-15 14:30:21 UTC
Reading https://bugzilla.redhat.com/show_bug.cgi?id=2110312#c13 it would still make sense to have the refcounts backported, re-opening.

Comment 8 Michael Catanzaro 2022-12-15 15:32:14 UTC
OK, sure.

Comment 9 Michael Catanzaro 2022-12-15 15:35:46 UTC
Actually it looks like you have an even simpler solution now, https://github.com/ibm-s390-linux/s390-tools/commit/394a6dd5eacf53633efa2064a307db760902602c, so I assume this can be closed? (Feel free to reopen if you still need it, but I think you don't.)

Comment 10 Michael Catanzaro 2022-12-15 15:36:35 UTC
Meh, I misread. I see you still want this anyway.

Comment 11 Dan Horák 2022-12-15 15:40:27 UTC
(In reply to Michael Catanzaro from comment #10)
> Meh, I misread. I see you still want this anyway.

yes, please, s390utils developers consider that commit as a short-term workaround. But if we can update glib2 for 8.8, then it won't be needed at the end.

Comment 14 Dan Horák 2023-01-12 11:31:44 UTC
for the record - I did a scratch build of unpatched s390utils in https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=50021763 and it confirms that the refcount support is included correctly in glib2-2.56.4-161.el8

Comment 15 Tomas Pelka 2023-01-12 11:35:24 UTC
(In reply to Dan Horák from comment #14)
> for the record - I did a scratch build of unpatched s390utils in
> https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=50021763 and it
> confirms that the refcount support is included correctly in
> glib2-2.56.4-161.el8

Thanks Dane, moving to VERIFIED based on your comment.

Comment 19 errata-xmlrpc 2023-05-16 09:10:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (glib2 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:3005


Note You need to log in before you can comment on or make changes to this bug.